Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rollback invocation after CmdAdd failure in CNI server #5548

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix rollback invocation after CmdAdd failure in CNI server #5548

merged 2 commits into from
Oct 9, 2023

Commits on Oct 9, 2023

  1. Fix rollback invocation after CmdAdd failure in CNI server 

    * When performing configuration rollback after an error in CmdAdd, we do
  not invoke CmdDel directly. Instead, we invoke an internal version of
  it which does not log a "Received CmdDel request" message (the message
  is confusing otherwise as it implies that we received a new CNI DEL
  command from the container runtime), and which does not process the
  network config again (as it was already processed at the beginning of
  CmdAdd). By not processing the config a second time, we ensure that
  there are no duplicate CIDRs in the IPAMConfig.
* Migrate klog calls in server.go to use structured logging.
* Improve unit tests for the CNI server to validate this fix.

Fixes antrea-io#5547

Signed-off-by: Antonin Bas <[email protected]>
    @antoninbas
    antoninbas committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a771f83 View commit details
    Browse the repository at this point in the history

  2. Fix existing comment 

    Signed-off-by: Antonin Bas <[email protected]>
    @antoninbas
    antoninbas committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6ab005d View commit details
    Browse the repository at this point in the history