Do not run tests when building OVS for UBI #6104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in antrea-io#6052. Signed-off-by: Xu Liu <[email protected]>
xliuxu
force-pushed
the
xliu2/disable-build-check-ubi
branch
from
d5643aa
to
be93e46
Compare
antoninbas
approved these changes
Mar 13, 2024
| # See https://github.com/openvswitch/ovs/blob/v2.17.7/rhel/openvswitch-fedora.spec.in#L26-L27. | ||
| RPMBUILD_OPT="--without libcapng" make rpm-fedora && mkdir -p /tmp/ovs-rpms && \ | ||
| RPMBUILD_OPT="--without libcapng --without check" make rpm-fedora && mkdir -p /tmp/ovs-rpms && \ |
There was a problem hiding this comment.
is this the default when RPMBUILD_OPT is not explicitly set?
There was a problem hiding this comment.
Yes. Please refer to https://github.com/openvswitch/ovs/blob/v2.17.7/rhel/automake.mk#L60
|
/skip-all |
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jun 14, 2024
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in antrea-io#6052. Signed-off-by: Xu Liu <[email protected]>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jun 14, 2024
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in antrea-io#6052. Signed-off-by: Xu Liu <[email protected]>
tnqn
pushed a commit
that referenced
this pull request
Jun 14, 2024
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in #6052. Signed-off-by: Xu Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds back the default
RPMBUILD_OPToption to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in #6052.