Clarify documentation for IPPool and ExternalIPPool CRDs #6183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When defining a pool with a CIDR, the first and the last IP address will usually be excluded. The last IP address (broadcast) is only excluded for IPv4, and, for IPPool, only if the prefix length matches the CIDR mask size. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added
the
kind/documentation
Signed-off-by: Antonin Bas <[email protected]>
|
@tnqn I fixed a typo (second commit), PTAL |
Atish-iaf
reviewed
Apr 3, 2024
Signed-off-by: Antonin Bas <[email protected]>
|
/skip-all |
jianjuns
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining a pool with a CIDR, the first and the last IP address will usually be excluded. The last IP address (broadcast) is only excluded for IPv4, and, for IPPool, only if the prefix length matches the CIDR mask size.