Add "-run" filter for antctl check installation command #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kanha-gupta |
tnqn
reviewed
May 16, 2024
To support running a subset only of tests, based on which test names match the provided regex. We also log stderr when `/agnhost connect` fails, to assist in troubleshooting. I have seen the `antctl check installation` command fail in CI, and at the moment it is impossible to troubleshoot. Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
antctl-check-installation-add-run-filter
branch
from
85d7143
to
d69175e
Compare
luolanzone
reviewed
May 17, 2024
| _, stderr, err := check.ExecInPod(ctx, t.client, t.config, t.namespace, clientPodName, container, cmd) | ||
| if err != nil { | ||
| // We log the contents of stderr here for troubleshooting purposes. | ||
| t.Log("/agnhost command failed - stderr: %s", stderr) |
There was a problem hiding this comment.
Maybe including the full cmd can also help here?
There was a problem hiding this comment.
I think it's ok right now because the command is always the same, and we have enough context from the surrounding log lines. If we add more complex commands, we can start logging them as well.
luolanzone
reviewed
May 17, 2024
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support running a subset only of tests, based on which test names match the provided regex.
We also log stderr when
/agnhost connectfails, to assist in troubleshooting. I have seen theantctl check installationcommand fail in CI, and at the moment it is impossible to troubleshoot.