Fix hint annotation implementation in AntreaProxy

[hongliangl]

This commit is to be consistent with kube-proxy's behavior for Topology
Aware Routing feature.

For service.kubernetes.io/topology-mode hint annotation, any non-empty
and non-disabled values for the annotation are acceptable to enable
Topology Aware Routing for a Service.

[tnqn]

LGTM

Please add description that this is to be consistent with kube-proxy's behavior.

[hongliangl]

LGTM

Please add description that this is to be consistent with kube-proxy's behavior.

Done

[tnqn]

I think setting the annotation value to other values wouldn't work because endpointslice controller only adds hints when the value is Auto or auto, so the PR is more to make code consistent with kube-proxy only. We don't need to backport and mention it in release note.

[tnqn]

I think setting the annotation value to other values wouldn't work because endpointslice controller only adds hints when the value is Auto or auto, so the PR is more to make code consistent with kube-proxy only. We don't need to backport and mention it in release note.

@hongliangl let me know if my understanding is correct.

[hongliangl]

I think setting the annotation value to other values wouldn't work because endpointslice controller only adds hints when the value is Auto or auto, so the PR is more to make code consistent with kube-proxy only. We don't need to backport and mention it in release note.

@tnqn You are right. Only Auto and auto are valid (https://github.com/kubernetes/kubernetes/blob/69dbf2eee96f1c95c097370ddcb1d5c30f86bec8/staging/src/k8s.io/endpointslice/utils.go#L360). This PR doesn't change the behavior.

[tnqn]

/skip-all

[tnqn]

/skip-all

[luolanzone]

@hongliangl are you going to back-port this to Antrea v2.0 and v2.1?

[hongliangl]

@hongliangl are you going to back-port this to Antrea v2.0 and v2.1?

No. See #6607 (comment)

[luolanzone]

@hongliangl are you going to back-port this to Antrea v2.0 and v2.1?

No. See #6607 (comment)

Ah, my bad, I didn't notice the label was already removed. Ignore me.