-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FlowAggregator] Add templateRefreshTimeout configuration #6699
Merged
antoninbas
merged 1 commit into
antrea-io:main
from
antoninbas:fa-add-templateRefreshTimeout-configuration
Oct 11, 2024
Merged
[FlowAggregator] Add templateRefreshTimeout configuration #6699
antoninbas
merged 1 commit into
antrea-io:main
from
antoninbas:fa-add-templateRefreshTimeout-configuration
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
area/flow-visibility/aggregator
Issues or PRs related to Flow Aggregator
action/release-note
Indicates a PR that should be included in release notes.
labels
Sep 27, 2024
Can be used to configure the template retransmission interval when using the UDP protocol to export records to an IPFIX collector. We also ensure that the default value is 600s, not 1800s, which is the value specified in RFC 6728. We do the same thing for the Agent Exporter, but this time by letting the go-ipfix library decide the value (we set it to 0 in ExporterInput to request the default). This is important because the templateRefreshTimeout config in the Agent's exporter and the templateTTL in teh Aggregator's collector must "match" (templateTTL = 3 x templateRefreshTimeout), and so it is better to let go-ipfix pick the right values for both. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
fa-add-templateRefreshTimeout-configuration
branch
from
October 1, 2024 20:07
346e01d
to
f57b7c0
Compare
heanlan
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There's a typo in the commit message
"templateTTL in teh Aggregator's" -> "templateTTL in the Aggregator's"
Thanks @heanlan, I can fix it when I squash and merge. |
/test-kind-all |
heanlan
approved these changes
Oct 9, 2024
/test-kind-all |
/test-all |
hangyan
pushed a commit
to hangyan/antrea
that referenced
this pull request
Oct 29, 2024
…6699) Can be used to configure the template retransmission interval when using the UDP protocol to export records to an IPFIX collector. We also ensure that the default value is 600s, not 1800s, which is the value specified in RFC 6728. We do the same thing for the Agent Exporter, but this time by letting the go-ipfix library decide the value (we set it to 0 in ExporterInput to request the default). This is important because the templateRefreshTimeout config in the Agent's exporter and the templateTTL in teh Aggregator's collector must "match" (templateTTL = 3 x templateRefreshTimeout), and so it is better to let go-ipfix pick the right values for both. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action/release-note
Indicates a PR that should be included in release notes.
area/flow-visibility/aggregator
Issues or PRs related to Flow Aggregator
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to configure the template retransmission interval when using the UDP protocol to export records to an IPFIX collector.
We also ensure that the default value is 600s, not 1800s, which is the value specified in RFC 6728. We do the same thing for the Agent Exporter, but this time by letting the go-ipfix library decide the value (we set it to 0 in ExporterInput to request the default). This is important because the templateRefreshTimeout config in the Agent's exporter and the templateTTL in teh Aggregator's collector must "match" (templateTTL = 3 x templateRefreshTimeout), and so it is better to let go-ipfix pick the right values for both.