Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupMod message should support selection_method and fields #42

Closed
tnqn opened this issue Jun 27, 2023 · 2 comments · Fixed by #43
Closed

GroupMod message should support selection_method and fields #42

tnqn opened this issue Jun 27, 2023 · 2 comments · Fixed by #43

Comments

@tnqn
Copy link
Member

tnqn commented Jun 27, 2023

To implement DSR in Antrea (antrea-io/antrea#5025), we need to use hash selection method and specify fields when installing a group for a service with DSR enabled (See antrea-io/antrea#5025 (comment) for reason). But the library doesn't support these fields.

@tnqn
Copy link
Member Author

tnqn commented Jun 27, 2023

@wenyingd I found selection_method is a Netronome extension, do you know where I can find how to construct a GroupMod message with these parameters?

@wenyingd
Copy link

I think we should firstly define a new struct for "Netronome selection_method" (https://github.com/openvswitch/ovs/blob/903294cde6e19b3eccefee13875f83b5ada2774c/include/openflow/netronome-ext.h#L36C8-L36C39), then append it into GroupMod.Properties (https://github.com/antrea-io/libOpenflow/blob/main/openflow15/group.go#L62)

A valid "Netronome selection_method" can be constructed reffering to https://github.com/openvswitch/ovs/blob/master/lib/ofp-group.c#L1210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants