Add support to set selection_method in GroupMod #43
Conversation
|
I am a bit confused if we should bump up the version to 0.12.0 rather than 0.11.1 for this change, any idea @tnqn @antoninbas ? |
openflow15/group.go
Outdated
| // padding with 4 bytes. | ||
| SelectionMethod [16]byte | ||
| SelectionParam uint64 | ||
| // Note, a valid field is supposed to configure with "HasMask==false", and its Value is to apply |
There was a problem hiding this comment.
what does it mean "HasMask==false"? We can't use masked field here?
There was a problem hiding this comment.
It means when we construct a MatchField object, the "HasMask" property must be set as false. So we only set "MatchField.Value", but not set "MatchField.Mask". The specified value is actually used to mask on the the given field in a packet by OVS.
Maybe 0.12.0 since you are adding a new public API? |
Got it, updated. |
|
@tnqn Could you help review this change? |
openflow15/group.go
Outdated
| SelectionMethod [16]byte | ||
| SelectionParam uint64 | ||
| // Note, a valid field is supposed to configure with MatchField.HasMask=false, and OVS will apply its | ||
| // Value to the packet field as a mask. |
There was a problem hiding this comment.
Was the comment copied from the original C code?
There was a problem hiding this comment.
The requirement is from OVS code, but the sentence is not directly copied from OVS code, "MatchField", "HasMask" are struct or property defined in libOpenflow
There was a problem hiding this comment.
How about adding single quote to surround them?
Add support for setting selection_method, selection_method_param and fields in a GroupMod message, the supported selection_method including "hash" and "dp_hash". When using "dp_hash", fields is supposed to be empty. "fields" could use a mask value or not, all bits in the value should be 1 if no mask is specified. Signed-off-by: wenyingd <[email protected]>
Add support for setting selection_method, selection_method_param and fields in a GroupMod message, the supported selection_method including "hash" and "dp_hash". When using "dp_hash", fields is supposed to be empty. "fields" could use a mask value or not, all bits in the value should be 1 if no mask is specified.
Fix: #42