Error handling for AppliedToGroup SG delete. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/nephe-test-e2e-kind |
Consider a scenario where ANP contains two rule level AppliedToGroups. Delete one of the AppliedToGroup. If the ATGroup could not deleted on the cloud, then the internal state of network policy controller still contains the rules, while the rules are deleted on the cloud. This PR tries addresses the issue, by clearing the internal state when an ATGroup is deleted, so that if the ATGroup is re-added, then NP controller will be able to recover and realize the rules on the cloud. Signed-off-by: Anand Kumar <[email protected]>
|
/nephe-test-e2e-agentless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a scenario where ANP contains two rule-level AppliedToGroups. Delete one of the AppliedToGroup. If the ATGroup could not be deleted on the cloud, then the internal state of NP controller still contains the rules, while the rules are deleted on the cloud.
This PR tries to address the issue, by clearing the internal state when an ATGroup is deleted, so that if the ATGroup is re-added, then NP controller will be able to recover and realize the rules on the cloud.