Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused shell version ClickHouse data migration code #155

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

yanjunz97
Copy link
Contributor

@yanjunz97 yanjunz97 commented Jan 27, 2023

We replace the shell version ClickHouse data migration by the Golang version in Theia v0.3.

The unused bash code and migrators for the bash version ClickHouse data migration
are removed in this PR.

Signed-off-by: Yanjun Zhou [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #155 (fcbd0b6) into main (b1ce1cd) will increase coverage by 9.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   41.04%   50.30%   +9.26%     
==========================================
  Files          81       54      -27     
  Lines        5806     3886    -1920     
==========================================
- Hits         2383     1955     -428     
+ Misses       3200     1739    -1461     
+ Partials      223      192      -31     
Flag Coverage Δ
unit-tests 50.30% <ø> (+9.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
snowflake/cmd/receiveSqsMessage.go
...wflake/pkg/aws/client/s3/testing/mock_interface.go
snowflake/cmd/policyRecommendation.go
snowflake/pkg/aws/client/s3/client.go
snowflake/pkg/infra/backends.go
snowflake/pkg/snowflake/snowflake.go
snowflake/pkg/aws/client/s3/region.go
snowflake/pkg/infra/manager.go
snowflake/cmd/createKmsKey.go
snowflake/pkg/aws/client/kms/client.go
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yanjunz97 yanjunz97 merged commit 184eb6a into antrea-io:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants