Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ClickHouse volume ownership #557

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #557 (ab5a99b) into main (6315647) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   70.51%   70.56%   +0.05%     
==========================================
  Files          40       40              
  Lines        5253     5253              
==========================================
+ Hits         3704     3707       +3     
+ Misses       1372     1370       -2     
+ Partials      177      176       -1     
Flag Coverage Δ *Carryforward flag
kind-e2e-tests 62.48% <ø> (ø)
kind-multi-cluster-e2e-tests 43.17% <ø> (ø)
python-coverage 55.75% <ø> (ø) Carriedforward from 6315647
unit-tests 70.15% <ø> (-0.11%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@yuntanghsu
Copy link
Contributor

Thanks Yanjun for takeing care this. Do you think we will have similar issue for ZooKeeper or Grafana? I couldn't reproduce the issue neither. Not sure what happened.

@yanjunz97
Copy link
Contributor Author

Thanks Yanjun for takeing care this. Do you think we will have similar issue for ZooKeeper or Grafana? I couldn't reproduce the issue neither. Not sure what happened.

ZooKeeper and Grafana should be fine.

I remember we have similar work on grafana side for this at

- name: init-pv
image: projects.registry.vmware.com/antrea/busybox
imagePullPolicy: IfNotPresent
command: ["chown", "-R", "472:472", "/data"]
volumeMounts:
- mountPath: /data
name: grafana-pv

As for zookeeper, I also find some code here which seems to take care of the folder ownership issue
chown -Rv zookeeper "$ZOO_DATA_DIR" "$ZOO_DATA_LOG_DIR" "$ZOO_LOG_DIR" "$ZOO_CONF_DIR" &&
zkServer.sh start-foreground

Copy link
Contributor

@yuntanghsu yuntanghsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanjunz97 yanjunz97 merged commit 607a419 into antrea-io:main Oct 17, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants