Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve tooltip debounce #2733

Merged
merged 2 commits into from
Aug 6, 2020
Merged

fix: resolve tooltip debounce #2733

merged 2 commits into from
Aug 6, 2020

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Aug 6, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

解决 tooltip customContent 频繁闪动问题。

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

'visibility 0.2s cubic-bezier(0.23, 1, 0.32, 1), ' +
'left 0.4s cubic-bezier(0.23, 1, 0.32, 1), ' +
'top 0.4s cubic-bezier(0.23, 1, 0.32, 1)',
transition: 'left 0.4s cubic-bezier(0.23, 1, 0.32, 1) 0s, top 0.4s cubic-bezier(0.23, 1, 0.32, 1) 0s;',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最末尾过了个分号。

可以截屏看看效果吗

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aug-06-2020 14-36-28

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改动后

@simaQ simaQ merged commit f5114f4 into master Aug 6, 2020
@simaQ simaQ deleted the fix/tooltipDebounce branch August 6, 2020 07:00
@hustcc
Copy link
Member

hustcc commented Aug 6, 2020

问题的原因是 visibility 的动画,导致闪烁吗?

@lxfu1
Copy link
Member Author

lxfu1 commented Aug 6, 2020

问题的原因是 visibility 的动画,导致闪烁吗?

是的 visibility 来回切换导致闪动。

@goalbased
Copy link

在餅圖上該問題沒有被解決。

@hustcc
Copy link
Member

hustcc commented Aug 27, 2020

@lxfu1 忙伐继续看一下~~~ @goalbased 给一个你这边有问题的 demo 吧~

在餅圖上該問題沒有被解決。

@goalbased
Copy link

@lxfu1 忙伐继续看一下~~~ @goalbased 给一个你这边有问题的 demo 吧~

在餅圖上該問題沒有被解決。

抱歉,應該是我專案版本相依性導致,我專案裡還有另外import antv/g2 ,開一個全新專案餅圖是沒問題的,謝謝幫助。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants