-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve tooltip debounce #2733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
src/util/theme.ts
Outdated
'visibility 0.2s cubic-bezier(0.23, 1, 0.32, 1), ' + | ||
'left 0.4s cubic-bezier(0.23, 1, 0.32, 1), ' + | ||
'top 0.4s cubic-bezier(0.23, 1, 0.32, 1)', | ||
transition: 'left 0.4s cubic-bezier(0.23, 1, 0.32, 1) 0s, top 0.4s cubic-bezier(0.23, 1, 0.32, 1) 0s;', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最末尾过了个分号。
可以截屏看看效果吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改动后
问题的原因是 visibility 的动画,导致闪烁吗? |
是的 visibility 来回切换导致闪动。 |
在餅圖上該問題沒有被解決。 |
@lxfu1 忙伐继续看一下~~~ @goalbased 给一个你这边有问题的 demo 吧~
|
抱歉,應該是我專案版本相依性導致,我專案裡還有另外import |
Checklist
npm test
passesDescription of change
解决 tooltip customContent 频繁闪动问题。