Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add graphin props setting to sdk config #587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add graphin props setting to sdk config #587

wants to merge 1 commit into from
+8 −9

Conversation

Seventysevendays
Copy link
Collaborator

  • add graphin props setting to sdk config

Aarebecca
Aarebecca reviewed Apr 12, 2024
View reviewed changes
package.json Outdated
@@ -78,5 +78,6 @@
"turbo": "^1.8.3",
"webpack": "^5.88.0",
"webpack-cli": "^5.0.0"
}
},
"version": "0.0.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个版本号不太需要

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

升级下 gi-sdk 的版本号就好了

lxfu1
lxfu1 reviewed Apr 12, 2024
View reviewed changes
packages/gi-sdk/src/GISDK.tsx
@@ -20,7 +20,7 @@ let updateHistoryTimer: number;
const GISDK = (props: Props) => {
const graphinRef = React.useRef<null | Graphin>(null);
// @ts-ignore
const { children, assets, id, services, config, locales } = props;
const { children, assets, id, services, config, locales, grapinProps } = props;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉不用新增一个 grapinProps 吧，和 layout 这类配置放一起就好

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉不用新增一个 grapinProps 吧，和 layout 这类配置放一起就好

animate、style、containerStyle... 等等一堆配置，后边这样一个个加进来么？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxfu1 lxfu1 lxfu1 left review comments

@Aarebecca Aarebecca Aarebecca left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seventysevendays @Aarebecca @lxfu1