fix: 🐛 not create label when text is empty

antvis · Jan 21, 2022 · 1ce2f3f · 1ce2f3f
1 parent 3cc518e
commit 1ce2f3f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/packages/x6/src/registry/tool/editor.ts b/packages/x6/src/registry/tool/editor.ts
@@ -99,7 +99,7 @@ export class CellEditor extends ToolsView.ToolItem<
       const value = this.editor.innerText.replace(/\n$/, '') || ''
       // set value
       const setText = this.options.setText
-      if (typeof setText === 'function') {
+      if (value !== '' && typeof setText === 'function') {
         FunctionExt.call(setText, this.cellView, {
           cell: this.cell,
           value,

diff --git a/sites/x6-sites-demos/packages/api/registry/node-tool/editor/src/app.tsx b/sites/x6-sites-demos/packages/api/registry/node-tool/editor/src/app.tsx
@@ -54,9 +54,11 @@ export default class Example extends React.Component {
     })
 
     graph.on('cell:dblclick', ({ cell, e }) => {
+      const name = cell.isEdge() ? 'edge-editor' : 'node-editor'
+      cell.removeTool(name)
       cell.addTools([
         {
-          name: cell.isEdge() ? 'edge-editor' : 'node-editor',
+          name,
           args: {
             event: e,
           },

diff --git a/sites/x6-sites/examples/node/tool/demo/editable.ts b/sites/x6-sites/examples/node/tool/demo/editable.ts
@@ -48,8 +48,10 @@ graph.addEdge({
 
 graph.on('cell:dblclick', ({ cell, e }) => {
   const isNode = cell.isNode()
+  const name = cell.isNode() ? 'node-editor' : 'edge-editor'
+  cell.removeTool(name)
   cell.addTools({
-    name: isNode ? 'node-editor' : 'edge-editor',
+    name,
     args: {
       event: e,
       attrs: {