fix: 🐛 not rerender tools when edge update (#2095)

antvis · May 9, 2022 · 26ce96f · 26ce96f
1 parent cfb77ae
commit 26ce96f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/packages/x6/src/view/edge.ts b/packages/x6/src/view/edge.ts
@@ -202,6 +202,7 @@ export class EdgeView<
     this.renderMarkup()
     this.renderLabels()
     this.update()
+    this.renderExternalTools()
 
     return this
   }
@@ -541,12 +542,7 @@ export class EdgeView<
     this.updateLabelPositions()
     this.updateToolsPosition()
     this.updateArrowheadMarkers()
-
-    if (options.toolId == null) {
-      this.renderExternalTools()
-    } else {
-      this.updateTools(options)
-    }
+    this.updateTools(options)
 
     return this
   }

diff --git a/packages/x6/src/view/tool.ts b/packages/x6/src/view/tool.ts
@@ -327,7 +327,7 @@ export namespace ToolsView {
 
     protected cellView: TargetView
 
-    protected visible: boolean
+    protected visible = true
 
     protected childNodes: KeyValue<Element>
 
@@ -440,7 +440,7 @@ export namespace ToolsView {
     }
 
     isVisible() {
-      return this.visible
+      return !!this.visible
     }
 
     focus() {