Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 stop propagation when enable following #1398

Merged
merged 1 commit into from
Oct 2, 2021
Merged

fix: 🐛 stop propagation when enable following #1398

merged 1 commit into from
Oct 2, 2021

Conversation

NewByVector
Copy link
Contributor

Description

  1. 解决在 selecting 中 following 设置为 false 时，节点移动异常问题

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@NewByVector NewByVector linked an issue Oct 2, 2021 that may be closed by this pull request
Selection 插件的 following 选项表现异常，拖动节点被移动2次 #1328
Closed
@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. pkg:x6 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2021
@codecov
Copy link

codecov bot commented Oct 2, 2021 •
edited
Loading

Codecov Report

Merging #1398 (b36be3c) into master (37eb7b9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1398   +/-   ##
=======================================
  Coverage   39.21%   39.21%           
=======================================
  Files         601      601           
  Lines       33511    33511           
  Branches     6807     6807           
=======================================
  Hits        13143    13143           
  Misses      19574    19574           
  Partials      794      794
Flag Coverage Δ
x6 27.00% <0.00%> (ø)
x6-geometry 47.91% <ø> (ø)
x6-vector 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/addon/selection/index.ts 14.18% <0.00%> (ø)

@NewByVector NewByVector merged commit 59cbe44 into master Oct 2, 2021
@NewByVector NewByVector deleted the fix-following branch October 2, 2021 11:07
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Oct 2, 2021
github-actions bot pushed a commit that referenced this pull request Oct 2, 2021
chore(release): @antv/[email protected] [skip ci]
da040a9 
# @antv/x6 [1.28.0](https://github.com/antvis/x6/compare/@antv/[email protected]...@antv/[email protected]) (2021-10-02)

### Bug Fixes

* 🐛 modify the font size even if the text does not change ([#1397](#1397)) ([f93c290](f93c290))
* 🐛 stop propagation when enable following ([#1398](#1398)) ([59cbe44](59cbe44))

### Features

* ✨ add batch for selection ([#1399](#1399)) ([276abac](276abac))
* ✨ add excludeHiddenNodes for manhattan router ([#1400](#1400)) ([c57908f](c57908f))
@x6-bot
Copy link
Contributor

x6-bot bot commented Oct 2, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot x6-bot bot added the released PR has released label Oct 2, 2021
@x6-bot
Copy link
Contributor

x6-bot bot commented Oct 12, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot
Copy link
Contributor

x6-bot bot commented Oct 19, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 8, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

bubkoo pushed a commit that referenced this pull request Nov 11, 2021
@NewByVector @bubkoo
fix: 🐛 stop propagation when enable following (#1398)
ac35422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: merged PR has merged. released PR has released size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selection 插件的 following 选项表现异常，拖动节点被移动2次
1 participant
@NewByVector