Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't dispose graph view #4023

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: don't dispose graph view #4023

merged 1 commit into from
Nov 9, 2023

Conversation

NewByVector
Copy link
Contributor

Description

fix: don't dispose graph view

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. PR(fix) :bug: Bug Fix PR: unreviewed PR does not have any reviews. pkg:x6 labels Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #4023 (e058d12) into master (9efe791) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4023   +/-   ##
=======================================
  Coverage   10.38%   10.38%           
=======================================
  Files         180      180           
  Lines       10546    10546           
  Branches     2567     2567           
=======================================
  Hits         1095     1095           
  Misses       9362     9362           
  Partials       89       89           
Flag Coverage Δ
x6 10.38% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/view/view.ts 6.52% <50.00%> (ø)

@NewByVector NewByVector merged commit 3141593 into master Nov 9, 2023
17 checks passed
@NewByVector NewByVector deleted the fix/dispose branch November 9, 2023 11:04
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Nov 9, 2023
@cyrilluce
Copy link
Contributor

@NewByVector 请问这个改动的原因是什么?注释掉后,现在又会有内存不能释放的问题

cyrilluce pushed a commit to cyrilluce/X6 that referenced this pull request Dec 22, 2023
NewByVector pushed a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:x6 PR(fix) :bug: Bug Fix PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants