fix: optimize drag performance while selecting multiple nodes #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x6-bot
bot
added
size/XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4201 +/- ##
==========================================
- Coverage 10.36% 10.35% -0.01%
==========================================
Files 180 180
Lines 10563 10572 +9
Branches 2572 2574 +2
==========================================
Hits 1095 1095
- Misses 9379 9388 +9
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. |
xiawenqi
changed the title
|
egde 的事件忘了？ |
NewByVector
requested changes
Apr 28, 2024
| @@ -83,7 +83,8 @@ export class SelectionImpl extends View<SelectionImpl.EventArgs> { | |||
| collection.on('reseted', this.onReseted, this) | |||
| collection.on('updated', this.onCollectionUpdated, this) | |||
| collection.on('node:change:position', this.onNodePositionChanged, this) | |||
| collection.on('cell:changed', this.onCellChanged, this) | |||
| collection.on('node:change:angle', this.onCellChanged, this) | |||
There was a problem hiding this comment.
使用 cell:changed 确实会执行过于频繁。不过导致 box 修改的事件应该不止 angle/size 修改。
x6-bot
bot
added
PR: reviewed-changes-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #1325
Motivation and Context
当利用框选插件选中多个节点时，拖拽性能下降非常严重。主要原因是插件监听了节点的change事件，当节点拖拽时多次触发重新创建节点，大量的DOM操作导致页面卡顿。
解决方式为不再在节点change时触发重新创建选框，改为分别监听节点的position、angle、size变更事件，position时只需要变更选框位置，angle和size变更时重绘选框DOM。
对比选中200节点时的拖拽效果, 优化前：
before.mp4
优化后：
after.mp4
Types of changes
Self Check before Merge