Support hide_progress for top-langs feature

[amirhakimnejad]

No description provided.

[vercel]

@amirhakimnejad is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

[amirhakimnejad]

Example:

Before:

[Zo-Bro-23]

Hi, thanks for the high quality PR! A few things before we merge:

• No need to make changes to the docs in all languages! It's really amazing that you've taken the time to do that, but we're unfortunately in the process of migrating to an automated translation system, so we're not accepting any PRs regarding translated docs. I appreciate that you've taken the time to do that, and I apologize for the miscommunication.
• Please see my comment above regarding variable names. (this is fine as is)
• I would think this is a valuable PR, but I'm not sure about the use case. Why would someone want to make the progress bars equal? It would be misleading to think that they spent equal time on all their languages. Hiding the percentages is a good feature, but again, I'm not sure about switching to compact mode. If the equal bars feature is removed, hiding percentages would make as much sense in the default layout as in the compact layout. Please consider my suggestion! @rickstaa please feel free to add your thoughts...

[amirhakimnejad]

Hi, thanks for the high quality PR! A few things before we merge:

Hello, and thank you.

• No need to make changes to the docs in all languages! It's really amazing that you've taken the time to do that, but we're unfortunately in the process of migrating to an automated translation system, so we're not accepting any PRs regarding translated docs. I appreciate that you've taken the time to do that, and I apologize for the miscommunication.

Oh, okay, the translation system seems incredible.

• I would think this is a valuable PR, but I'm not sure about the use case. Why would someone want to make the progress bars equal? It would be misleading to think that they spent equal time on all their languages. Hiding the percentages is a good feature, but again, I'm not sure about switching to compact mode. If the equal bars feature is removed, hiding percentages would make as much sense in the default layout as in the compact layout. Please consider my suggestion! @rickstaa please feel free to add your thoughts...

About the progress bar. In the hire_progress=true scenario, I only thought of it as juice, having the language colors instead of removing the bars. You're right; I can hide it.

About the default mode, I thought they would be so much alike, also, having a language per line without a progress bar looked a bit unnecessarily space-consuming.

I agree with anything you guys decide and will fix the issues.

Thank you for the useful repo

[Zo-Bro-23]

I still think the progress bars should show accurate progress. Otherwise, it will be misleading. I agree that the compact layout makes more sense, but the problem is that this parameter will then essentially modify another parameter, which I don't think should be the case. I still think you should show accurate progress and remove the compact layout check, but @rickstaa and @anuraghazra can override me if they think otherwise.

Also, due to the popularity of the repo, we require at least two reviews before merging, which is why I requested a review from @rickstaa.

[amirhakimnejad]

I still think the progress bars should show accurate progress. Otherwise, it will be misleading. I agree that the compact layout makes more sense, but the problem is that this parameter will then essentially modify another parameter, which I don't think should be the case. I still think you should show accurate progress and remove the compact layout check, but @rickstaa and @anuraghazra can override me if they think otherwise.

Hmmm, maybe hiding the bars would be better. In my own use case, one of my used languages was gaining too much unwanted weight in the parameters, and I wanted to avoid it. But about the accuracy, you're right.
If there is a bar, it should be accurate; otherwise, it should be hidden.

So based on my own case, do you think I should keep the bars accurate with hidden percentages, or hide the bars, too?
Both seem reasonable to me, though. I agree anyways

[Zo-Bro-23]

I still think the progress bars should show accurate progress. Otherwise, it will be misleading. I agree that the compact layout makes more sense, but the problem is that this parameter will then essentially modify another parameter, which I don't think should be the case. I still think you should show accurate progress and remove the compact layout check, but @rickstaa and @anuraghazra can override me if they think otherwise.

Hmmm, maybe hiding the bars would be better. In my own use case, one of my used languages was gaining too much unwanted weight in the parameters, and I wanted to avoid it. But about the accuracy, you're right. If there is a bar, it should be accurate; otherwise, it should be hidden.

So based on my own case, do you think I should keep the bars accurate with hidden percentages, or hide the bars, too? Both seem reasonable to me, though. I agree anyways

Both are fine, but hiding the bars entirely would make more sense, since hiding the labels alone wouldn't do much (you can still guess the percentage based on the bars). Let me play around with the code a bit and see what I can do (I'll make commits directly to your branch).

[amirhakimnejad]

Both are fine, but hiding the bars entirely would make more sense, since hiding the labels alone wouldn't do much (you can still guess the percentage based on the bars). Let me play around with the code a bit and see what I can do (I'll make commits directly to your branch).

Mhm, ok thank you. Let me know if I should change anything.

[Zo-Bro-23]

@amirhakimnejad I've made the necessary changes. Please revert the translated docs so that we can merge!

[amirhakimnejad]

Thank you, @Zo-Bro-23 , I just pushed the revert.

[Zo-Bro-23]

We are go for merge 👍

[Zo-Bro-23]

Merged 🎉