Demo check: Here are the changes that I made to reproduce Figures 4 and 7 from the paper #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anurag,
Thanks for the chat recently! I thought I'd share the changes that I made to reproduce the results from the paper. I figured that maybe if you find the time to review and integrate the changes, you could find this useful.
As you suggested, I changed the way that
test_flow.py
calculates the masks to be identical to the waytest_mask.py
does it. Accordingly, I also had to change the defaults for the mask threshold because, in the original version, the default mask threshold was .01 fortest_flow.py
and .94 fortest_mask.py
. It is now .94 for both. The results are now very close to what you can see in the original paper! (It might take some tweaking with the threshold to make them identical.)Some other changes (I almost forgot) I had to make along the way:
grid_sample
in PyTorch has changed. Needed to setalign_corners
accordingly to achieve old behavior.volatile
is no longer supported in PyTorch. I usedwith torch.no_grad
, as PyTorch suggests.Cheers,
Michael