This repository has been archived by the owner on Feb 25, 2019. It is now read-only.
feat(RPInitiatedLogoutRequest): First draft of RP Initiated Logout Request handling #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrizagidulin
force-pushed
the
rp_initiated_logout
branch
from
58957be
to
4e1c115
Compare
dmitrizagidulin
force-pushed
the
rp_initiated_logout
branch
from
2db5dfb
to
d7b1b96
Compare
dmitrizagidulin
commented
Jan 11, 2017
| @@ -28,8 +28,8 @@ class AuthenticationRequest extends BaseRequest { | |||
| Promise | |||
| .resolve(request) | |||
| .then(request.validate) | |||
| .then(host.authenticate) // QUESTION, what's the cleanest way to | |||
There was a problem hiding this comment.
Binds just fine the way it is.
|
Awesome work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #9. (RP Initiated Logout only, not Front Channel or Back Channel logouts)