This repository has been archived by the owner on Feb 25, 2019. It is now read-only.
fix: allow passing an algorithm name to digest #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples on [MDN][1] show strings passed as the first argument. I've tested that it actually works in browsers. The [specification][2] shows `AlgorithmIdentifier` as the first argument to `digest` and `AlgorithmIdentifier` is defined as `typedef (object or DOMString) AlgorithmIdentifier;` [1]: https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/digest [2]: https://www.w3.org/TR/WebCryptoAPI/#subtlecrypto-interface
|
I ran into the same issue today. fwiw, I'm using the code below to temporarily work around the issue until this PR is merged: window.crypto.__proto__.subtle.__proto__.digest = (digest => (name, data) => digest({ name }, data))(window.crypto.subtle.digest); |
|
Yeah, although the MDN documentation shows that you can provide an algorithm name as a string, this library expects an object with a name property. Until this is fixed, I guess I'm going to have to use the following format: crypto.subtle.digest({name: 'SHA-512'}, data) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples on MDN show strings passed as the first argument. I've tested that it actually works in browsers.
The specification shows
AlgorithmIdentifieras the first argument todigestandAlgorithmIdentifieris defined astypedef (object or DOMString) AlgorithmIdentifier;I've only briefly looked at the rest of the API but it seems to me the problem recurs elsewhere: the algorithm is normalized but instead of passing the normalized algorithm to the backend code, the original unnormalized value is passed. I only depend on
digestright now and do not use the rest of the API so I've decided to not touch the rest of the API, but I suspect a similar change needs to be applied to other API functions.