Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a relative path to the source line to address #13 #14

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

mmroden
Copy link

@mmroden mmroden commented Mar 25, 2021

Attempts to address issue #13 by adding in a relative path. Would require some testing to make sure it works for other people.

@anvithks
Copy link
Owner

Thanks for the PR @mmroden .
I will set this up on the demo and test it out locally.
As suggested am working on setting up some sort of a test environment where fixes and PRs can be deployed.

@anvithks anvithks linked an issue Mar 25, 2021 that may be closed by this pull request
The double quotes were throwing an error in the IDE when used enclosed by another double quote.
Fixed for better readability.
Copy link
Owner

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you @mmroden

@anvithks anvithks merged commit f0d96aa into anvithks:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I'm sorry but, it doesn't work for me
2 participants