Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to select initial page number #17

Merged
merged 3 commits into from
Aug 29, 2021

Conversation

jeremybohannon
Copy link
Contributor

@jeremybohannon jeremybohannon commented Jun 5, 2021

++Added ability to select initial page number
Closes #1

@anvithks
Copy link
Owner

@jeremybohannon Thank you for this PR.
I will review shortly and merge if all is OK.

@anvithks anvithks added feature enhancement New feature or request and removed feature labels Jun 26, 2021
anvithks
anvithks previously approved these changes Aug 28, 2021
Copy link
Owner

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

var numPages = pdfDoc.numPages;
document.getElementById('page_count').textContent = numPages;

// If the user passed in a number that is out of range, render the last page.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thoughtful!

Copy link
Owner

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks anvithks merged commit e309a62 into anvithks:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to select specific page from the pdf to embed in the document
2 participants