Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow embedding multiple PDF on the same page #32

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Allow embedding multiple PDF on the same page #32

merged 6 commits into from
Mar 15, 2023

Conversation

RoneoOrg
Copy link
Contributor

Fixes #25

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RoneoOrg RoneoOrg mentioned this pull request Sep 30, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

anvithks
anvithks approved these changes Mar 15, 2023
View reviewed changes
Copy link
Owner

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RoneoOrg and @chtzvt for this!
I updated the code based on the previous PRs and added the latest version of the PDF.js

@anvithks anvithks merged commit 38c0dd0 into anvithks:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvithks anvithks anvithks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple PDF embeddings in one page
3 participants
@RoneoOrg @anvithks @chtzvt