Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with My subscription #888

Closed
drrak opened this issue Aug 24, 2024 · 18 comments
Closed

Problem with My subscription #888

drrak opened this issue Aug 24, 2024 · 18 comments
Labels
bug Something isn't working

Comments

@drrak
Copy link
Contributor

drrak commented Aug 24, 2024

Translator:
They just don't work properly.

RPi 4,, LibreELEC 12.0.0, YouTube 7.0.9.1

@drrak drrak added the bug Something isn't working label Aug 24, 2024
@MoojMidge
Copy link
Collaborator

Post a log

@Mo1967
Copy link

Mo1967 commented Aug 25, 2024

I think that's true.
With v7.0.9.1 get old (deleted) content in My Subscriptions, only.

Here different to v7.0.9 with current content:

kodi with v7.0.9.log
kodi with v7.0.9.1.log

Screenshot with v7.0.9 (current right content)

My Subscriptions  v7 0 9

Screenshot with v7.0.9.1 (wrong content, from old deleted subscriptions only)

My Subscriptions  v7 0 9,1

@MoojMidge
Copy link
Collaborator

Thanks for that. Unfortunately your device doesn't actually log debug info even when it is enabled.

Can you get me a normal log using the following test version?
https://github.com/MoojMidge/plugin.video.youtube/archive/refs/heads/extra_logging.zip

@Mo1967
Copy link

Mo1967 commented Aug 25, 2024

@MoojMidge
let me know for further support.
kodi with v7.0.9.1 test version.log

@MoojMidge
Copy link
Collaborator

Thanks. It's a bit strange, but I can see what the problem is. Need to figure out what can be done

@Mo1967
Copy link

Mo1967 commented Aug 25, 2024

Thanks. It's a bit strange, but I can see what the problem is. Need to figure out what can be done

Great.
BTW: In 'My Subscription' for the the other user (wife), the content are up to date in v 7.0.9.1

@MoojMidge
Copy link
Collaborator

Yeah it is a timing issue. For some reason the threads are being delayed and depending on the number of subscriptions or bookmarks you have, the fetching of new videos may be stopped before the delayed threads fully complete

@Mo1967
Copy link

Mo1967 commented Aug 25, 2024

Tested......
Maintenance -> Clear bookmarks list-> now for both user the right content of 'My Subscription'.
With errors in the log, but working correct
kodi.with.v7.0.9.1.test.version Part II.log

MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Aug 25, 2024
@MoojMidge
Copy link
Collaborator

With errors in the log, but working correct

Those are fake errors, just normal debug log entries but changed to error messages, otherwise they wouldn't show up in your logs because of the particular device you are using.

You had one bookmark previously which was enough to trigger the problem because of the delay in thread execution. Can you bookmark one channel again and confirm that the issue re-occurs?

Can you then try with this new test version and confirm that it now works correctly?
https://github.com/MoojMidge/plugin.video.youtube/archive/refs/heads/master.zip

@Mo1967
Copy link

Mo1967 commented Aug 25, 2024

confirm it, works for both user with bookmarked channel. Thank you.
kodi with YT master.log

@MoojMidge
Copy link
Collaborator

Great, thanks for testing!

@MoojMidge
Copy link
Collaborator

@DjDiabolik, @C-O-D, @DJMix-I-Can - can you test this version as well and confirm your issues with My Subscriptions do not re-occur:
https://github.com/MoojMidge/plugin.video.youtube/archive/refs/heads/master.zip

@C-O-D
Copy link

C-O-D commented Aug 25, 2024

I'd say this looks pretty good - no problems so far: kodi.log

But maybe you could take a look at why the corresponding widget always disappears after starting a video from the widget? The problem has existed for a very long time and occurs with all of my skins and only with the YT addon: kodi_widget.log

This was referenced Aug 25, 2024
@DJMix-I-Can
Copy link

DJMix-I-Can commented Aug 25, 2024

Just tested it out & it's working fine. I noticed something last night when I was going to sleep. I have a Meditation playlist folder with misc ambience videos. I usually highlight the video, long press for the context menu & select "Play Audio Only". I do this so the screen can go dark. We were more focused on the "My Subscriptions" issue that I never thought about testing that out. On version 7.0.9.0 it was working, on 7.0.9.1 it works when it wants to. I would get an error BUT as soon as I back out of the playlist, the audio kicks in. I posted a log of it happening. 7.0.9.2 My Subscriptions & Play Audio Only are working fine. Even though, Play Audio Only is working now. I thought I'd mention it & provide a log for future references. Thanks.
kodi.log

@MoojMidge
Copy link
Collaborator

MoojMidge commented Aug 25, 2024

on 7.0.9.1 it works when it wants to. I would get an error BUT as soon as I back out of the playlist, the audio kicks in.

Yes, this was a side-effect of trying to fix #873. Was fixed by 4377cc3 in v7.0.9.2

@DjDiabolik
Copy link
Contributor

DjDiabolik commented Aug 26, 2024

I'm problably come back later for testing. On my side today i have used a lot the current 7.0.9.2.

With both option disabled:

  • Refresh after watching
  • Delete from "Watch Later" after watching

This version it's apparently have a good stable usage....... about 2 minutes ago maybe i'm going to exit from kodi and all it's freeze at during exit operation.

The last line on kodi.log speaking about another addons:
024-08-26 02:05:27.831 T:7 error <general>: CPythonInvoker(118, /home/diabolik/.var/app/tv.kodi.Kodi/data/addons/plugin.video.kod/default.py): script didn't stop in 5 seconds - let's kill it

a similar problem had already existed in the recent past... I had posted the debug log and the problem then disappeared with subsequent updates.
Could the same problem have reappeared?

EDIT
The old issue it's there:
#813
Looking the log the issue it's different.... now need more test. If i can repeat the issue or i open new issue or i can add another debug log on the old issue like similar.

EDIT 2nd
Warning... possible sporadic case. I have tryed to reproduce this issue (kodi can't exit) in this last 30 minutes... can't reproduce the issue.
maybe after more heavy use ? Only the future can say that :)

@MoojMidge
Copy link
Collaborator

With both option disabled:

  • Refresh after watching
  • Delete from "Watch Later" after watching

Planning to remove the refresh after watching setting, but in the meantime try with these enabled and see if there is an improvement compared to what was happening previously.

If i can repeat the issue or i open new issue or i can add another debug log on the old issue like similar.

None of the recent changes would be able to cause the previous problem to reoccur. If you are having an issue and suspect this plugin then you can open a new issue when you can get a debug log.

@DjDiabolik
Copy link
Contributor

None of the recent changes would be able to cause the previous problem to reoccur. If you are having an issue and suspect this plugin then you can open a new issue when you can get a debug log.

Yeah this it's ever valid..... Also today until 5 minutes ago i have watched about 8 / 9 youtube video in a row whitout any issue.
After that i exit from kodi whitout any issue and whitout any freeze.

I think Kodi itself is probably not new to these cases/problems that appear once and then disappear the next time you use it.
Already yesterday evening when I failed to "replicate" the issue i have editing previous reply :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants