-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to use a custom database number #189
Conversation
@palkan The extended test conformance output is fixed there - anycable/anyt#7 |
Locally no errors with NATS and NATS Embedded |
It seems that the hidden errors are timeouts - |
Have you tried upgrading |
Thanks! I pinned |
Okay, this is a real one: https://github.com/anycable/anycable-go/actions/runs/6154293794/job/16699510933 @ardecvz Could you please take a look? (And propose a follow-up PR?) |
Of course, NATS hides these failures. |
Yeah, it's fine. All the data we store has TTL. |
What is the purpose of this pull request?
Support to use a custom database number.
What changes did you make? (overview)
Parse
--redis_url
(ANYCABLE_REDIS_URL
orREDIS_URL
) using therueidis
standard utility.Is there anything you'd like reviewers to focus on?
WARNING! This could be a potentially breaking change. Prior to this update, AnyCable Go did not support database numbers but allowed them in the
REDIS_URL
. As a result, if a user had set a URL with a database number, all data would still be written to the default database (0
). After upgrading, this will break the existing user setup by starting to write data to the specified in the URL database, potentially leaving remnants in the old one.@palkan, it's critical for you to assess how important the data in the storage is and decide on the appropriate path for data migration (whether that be discarding the old data, issuing a warning, performing automatic migration, etc.).
Checklist
Fixes #188