Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upd] Release 0.10.0 - IAM policies updates for new AWS account #19

Merged
merged 1 commit into from
May 12, 2023

Conversation

brent-anyscale
Copy link
Collaborator

aws-anyscale-iam module:

  • After testing on an empty AWS account, we found additional IAM policies required for Services v2 and for Spot instances to work properly.
  • Removed the service linked role for ELB as this will be managed by the cloudformation template that manages services. This could be a breaking change.

Notes on the above. If the Service Account Role was created via Terraform, you may encounter an error updating to this latest version of the module as it's being removed. This can be dealt with in a couple ways:

  • If there are no services running, this should be able to be deleted. You can start by deleting the associated Cloudformation template for Anyscale Services.
  • If you have running services, you can remove the resource from the terraform state file.
  • You can also safely leave this particular service linked role alone, or manage it in a different terraform code block.

The Clouformation process that starts/manages Anyscale Services v2 will manage the Service Linked Role.

Examples:

  • Additional updates done to commonname example.

README updates with latest AWS Provider version.

On branch release-0.10.0
Changes to be committed:
modified: CHANGELOG.md
modified: examples/anyscale-v2-commonname/README.md
modified: examples/anyscale-v2-commonname/variables.tf
modified: examples/anyscale-v2-privatesubnets/outputs.tf
modified: modules/aws-anyscale-efs/README.md
modified: modules/aws-anyscale-iam/README.md
modified: modules/aws-anyscale-iam/data.tf
modified: modules/aws-anyscale-iam/iam-policies-data.tf
modified: modules/aws-anyscale-iam/main.tf
modified: modules/aws-anyscale-s3-policy/README.md
modified: modules/aws-anyscale-s3-policy/examples/README.md
modified: modules/aws-anyscale-s3/README.md
modified: modules/aws-anyscale-securitygroups/README.md
modified: modules/aws-anyscale-vpc/README.md

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

See above for notes on the breaking change related to removing the Service Linked Role for Elastic Load Balancing. If this role was created by these Terraform Modules, and is in use, updating to this version may cause errors.

aws-anyscale-iam module:
- After testing on an empty AWS account, we found additional IAM policies
required for Services v2 and for Spot instances to work properly.
- Removed the service linked role for ELB as this will be managed by the cloudformation template that manages services. This could be a breaking change.

Examples:
- Additional updates done to commonname example.

README updates with latest AWS Provider version.

On branch release-0.10.0
Changes to be committed:
	modified:   CHANGELOG.md
	modified:   examples/anyscale-v2-commonname/README.md
	modified:   examples/anyscale-v2-commonname/variables.tf
	modified:   examples/anyscale-v2-privatesubnets/outputs.tf
	modified:   modules/aws-anyscale-efs/README.md
	modified:   modules/aws-anyscale-iam/README.md
	modified:   modules/aws-anyscale-iam/data.tf
	modified:   modules/aws-anyscale-iam/iam-policies-data.tf
	modified:   modules/aws-anyscale-iam/main.tf
	modified:   modules/aws-anyscale-s3-policy/README.md
	modified:   modules/aws-anyscale-s3-policy/examples/README.md
	modified:   modules/aws-anyscale-s3/README.md
	modified:   modules/aws-anyscale-securitygroups/README.md
	modified:   modules/aws-anyscale-vpc/README.md
@brent-anyscale brent-anyscale added bug Something isn't working documentation Improvements or additions to documentation terraform-module-iam examples terraform labels May 12, 2023
@brent-anyscale brent-anyscale requested a review from a team as a code owner May 12, 2023 15:17
@domcatalano domcatalano merged commit 17bacdb into main May 12, 2023
@brent-anyscale brent-anyscale deleted the release-0.10.0 branch June 6, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation examples terraform terraform-module-iam
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants