Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Services] Added incremental permissions to be able to modify ALB resources after creation #30

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[Services] Added incremental permissions to be able to modify ALB resources after creation #30

merged 1 commit into from
Jul 11, 2023

Conversation

alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Jul 10, 2023 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Description

Does this introduce a breaking change?

  • Yes
  • No

Other information

@alexeykudinkin alexeykudinkin requested a review from a team as a code owner July 10, 2023 23:09
@brent-anyscale brent-anyscale added bug Something isn't working terraform-module-iam labels Jul 11, 2023
brent-anyscale
brent-anyscale approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@brent-anyscale brent-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we are performing all of these actions, but I don't see any reason to not allow them for future work.

@brent-anyscale brent-anyscale merged commit 82f354b into main Jul 11, 2023
3 checks passed
@brent-anyscale brent-anyscale deleted the ak/alb-prms-fix branch July 11, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brent-anyscale brent-anyscale brent-anyscale approved these changes

@sudhirn-anyscale sudhirn-anyscale Awaiting requested review from sudhirn-anyscale

Assignees
No one assigned
Labels
bug Something isn't working terraform terraform-module-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeykudinkin @brent-anyscale