feat: Add KMS support for EFS and S3 in Root module #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KMS support was enabled for S3, but additional functionality to support S3 Bucket Keys to manage costs, as well as EFS encryption was added. This commit also includes a new example for KMS encryption. Additional changes include: - VPC Subnet name changes to remove deprecated double lookup call. - README updates - Add functional-verify to example outputs - Upgrade pre-commit from tfsec (deprecated) to trivy - tflint updates - e2e test updates On branch brent/kms-support Changes to be committed: modified: .pre-commit-config.yaml modified: .tflint.hcl modified: CHANGELOG.md modified: README.md modified: examples/README.md modified: examples/anyscale-v2-commonname/outputs.tf modified: examples/anyscale-v2-existing-s3/outputs.tf modified: examples/anyscale-v2-existing-vpc/outputs.tf modified: examples/anyscale-v2-kitchensink/main.tf modified: examples/anyscale-v2-kitchensink/outputs.tf new file: examples/anyscale-v2-kms/README.md new file: examples/anyscale-v2-kms/data.tf new file: examples/anyscale-v2-kms/main.tf new file: examples/anyscale-v2-kms/outputs.tf new file: examples/anyscale-v2-kms/variables.tf new file: examples/anyscale-v2-kms/versions.tf modified: examples/anyscale-v2-privatesubnets/outputs.tf modified: main.tf modified: modules/aws-anyscale-efs/README.md modified: modules/aws-anyscale-efs/variables.tf modified: modules/aws-anyscale-iam/README.md modified: modules/aws-anyscale-iam/iam-policies-data.tf modified: modules/aws-anyscale-memorydb/README.md modified: modules/aws-anyscale-s3-policy/README.md modified: modules/aws-anyscale-s3-policy/examples/README.md modified: modules/aws-anyscale-s3-policy/variables.tf modified: modules/aws-anyscale-s3/README.md modified: modules/aws-anyscale-s3/main.tf modified: modules/aws-anyscale-s3/variables.tf modified: modules/aws-anyscale-securitygroups/README.md modified: modules/aws-anyscale-securitygroups/main.tf modified: modules/aws-anyscale-vpc/README.md modified: modules/aws-anyscale-vpc/main.tf modified: modules/aws-anyscale-vpc/subnets-private.tf modified: modules/aws-anyscale-vpc/subnets-public.tf modified: test/anyscale-v2-e2e-private-test/variables.tf modified: variables.tf
github-actions
bot
added
documentation
Changes to be committed: modified: examples/anyscale-v2-commonname/main.tf modified: examples/anyscale-v2-kms/main.tf modified: modules/aws-anyscale-iam/iam-policies-data.tf modified: modules/aws-anyscale-iam/main.tf modified: modules/aws-anyscale-securitygroups/main.tf modified: modules/aws-anyscale-vpc/main.tf modified: modules/aws-anyscale-vpc/subnets-public.tf
kylehh
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KMS support was enabled for S3, but additional functionality to support S3 Bucket Keys to manage costs, as well as EFS encryption was added.
This commit also includes a new example for KMS encryption.
Additional changes include:
On branch brent/kms-support
Changes to be committed:
modified: .pre-commit-config.yaml
modified: .tflint.hcl
modified: CHANGELOG.md
modified: README.md
modified: examples/README.md
modified: examples/anyscale-v2-commonname/outputs.tf
modified: examples/anyscale-v2-existing-s3/outputs.tf
modified: examples/anyscale-v2-existing-vpc/outputs.tf
modified: examples/anyscale-v2-kitchensink/main.tf
modified: examples/anyscale-v2-kitchensink/outputs.tf
new file: examples/anyscale-v2-kms/README.md
new file: examples/anyscale-v2-kms/data.tf
new file: examples/anyscale-v2-kms/main.tf
new file: examples/anyscale-v2-kms/outputs.tf
new file: examples/anyscale-v2-kms/variables.tf
new file: examples/anyscale-v2-kms/versions.tf
modified: examples/anyscale-v2-privatesubnets/outputs.tf
modified: main.tf
modified: modules/aws-anyscale-efs/README.md
modified: modules/aws-anyscale-efs/variables.tf
modified: modules/aws-anyscale-iam/README.md
modified: modules/aws-anyscale-iam/iam-policies-data.tf
modified: modules/aws-anyscale-memorydb/README.md
modified: modules/aws-anyscale-s3-policy/README.md
modified: modules/aws-anyscale-s3-policy/examples/README.md
modified: modules/aws-anyscale-s3-policy/variables.tf
modified: modules/aws-anyscale-s3/README.md
modified: modules/aws-anyscale-s3/main.tf
modified: modules/aws-anyscale-s3/variables.tf
modified: modules/aws-anyscale-securitygroups/README.md
modified: modules/aws-anyscale-securitygroups/main.tf
modified: modules/aws-anyscale-vpc/README.md
modified: modules/aws-anyscale-vpc/main.tf
modified: modules/aws-anyscale-vpc/subnets-private.tf
modified: modules/aws-anyscale-vpc/subnets-public.tf
modified: test/anyscale-v2-e2e-private-test/variables.tf
modified: variables.tf
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?