Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Example documentation for KMS #51

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

brent-anyscale
Copy link
Collaborator

Removed reference to us-east-2 in KMS example.
General cleanup on language and formatting in KMS example.

On branch brent/example-kms-cleanup
Changes to be committed:
modified: examples/anyscale-v2-kms/README.md
modified: examples/anyscale-v2-kms/main.tf

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Removed reference to `us-east-2` in KMS example.
General cleanup on language and formatting in KMS example.

On branch brent/example-kms-cleanup
Changes to be committed:
	modified:   examples/anyscale-v2-kms/README.md
	modified:   examples/anyscale-v2-kms/main.tf
@brent-anyscale brent-anyscale requested a review from a team as a code owner July 16, 2024 22:55
@github-actions github-actions bot added documentation Improvements or additions to documentation examples labels Jul 16, 2024
Changes to be committed:
	modified:   README.md
@brent-anyscale brent-anyscale merged commit d1d15d1 into main Sep 5, 2024
3 checks passed
@brent-anyscale brent-anyscale deleted the brent/example-kms-cleanup branch September 5, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants