fix: EKS Nodegroups - Use pinned version from Scaling Template #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original release of this used $LATEST which was causing each terraform apply to recalculate the launch template and update the nodegroups, even when there were no changes. This now utilizes the `latest_version` attribute from the `aws_launch_template` Changes to be committed: modified: CHANGELOG.md modified: modules/aws-anyscale-eks-nodegroups/main.tf modified: modules/aws-anyscale-iam/iam-policies-data.tf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original release of this used $LATEST which was causing each terraform apply to recalculate the launch template and update the nodegroups, even when there were no changes.
This now utilizes the
latest_versionattribute from theaws_launch_templateChanges to be committed:
modified: CHANGELOG.md
modified: modules/aws-anyscale-eks-nodegroups/main.tf
modified: modules/aws-anyscale-iam/iam-policies-data.tf
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?