Flaky Test: solana-runtime bank::tests::test_bank_update_sysvar_account

[anza-team]

AUTO-GENERATED. DO NOT EDIT.

📝 Buildkite Analytics

[steviez]

I saw one of these fail just now.
https://buildkite.com/anza/agave/builds/11601#01925922-690d-4b40-b66a-2f67a1d9a60c

failures:

---- bank::tests::test_bank_update_sysvar_account stdout ----
thread 'bank::tests::test_bank_update_sysvar_account' panicked at runtime/src/bank/tests.rs:3967:17:
assertion `left == right` failed
  left: 44
 right: 18446744073709551615

failures:
    bank::tests::test_bank_update_sysvar_account

Seeing the rent epoch fail intermittently is a bit surprising:

agave/runtime/src/bank/tests.rs

Lines 3948 to 3967 in 2b3f1ff

	bank2.update_sysvar_account(&dummy_clock_id, |optional_account| {
	let slot = from_account::<Clock, _>(optional_account.as_ref().unwrap())
	.unwrap()
	.slot
	+ 1;
	create_account(
	&Clock {
	slot,
	..Clock::default()
	},
	bank2.inherit_specially_retained_account_fields(optional_account),
	)
	});
	let current_account = bank2.get_account(&dummy_clock_id).unwrap();
	assert_eq!(
	expected_next_slot,
	from_account::<Clock, _>(&current_account).unwrap().slot
	);
	assert_eq!(dummy_rent_epoch, current_account.rent_epoch());

[brooksprumo]

Looks like this is conditional based on if the dummy pubkey and if it gets rent collection in this bank or not.

let dummy_clock_id = solana_sdk::pubkey::new_rand();

[steviez]

Good catch Brooks. From DM's, Brooks mentioned a couple potential ideas/options:

• Disable rent in the test
• Use a fixed pubkey that we know will get rent-collected
• Jump by an epoch so we know that the pubkey will get rent-collected no matter what the value is

I am not going to pick this up right now, so posting that above for when I come back and/or if somebody else picks this one up