Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes spurious failures in test_bank_update_sysvar_account #3209

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fixes spurious failures in test_bank_update_sysvar_account #3209

merged 1 commit into from
Oct 17, 2024

Conversation

brooksprumo
Copy link

Problem

Spurious failures in test_bank_update_sysvar_account(). See #3002 for more information.

Summary of Changes

Hardcode the pubkey to not have rent collection during the test.

Fixes #3002

@brooksprumo brooksprumo self-assigned this Oct 17, 2024
@brooksprumo brooksprumo changed the title Fixes spruious failures in test_bank_update_sysvar_account Fixes spurious failures in test_bank_update_sysvar_account Oct 17, 2024
@brooksprumo brooksprumo marked this pull request as ready for review October 17, 2024 20:43
apfitzge
apfitzge approved these changes Oct 17, 2024
View reviewed changes
Copy link

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this CI failure several times now.

Fix works (ran 100x loop). Random pubkey causing it to be random makes sense.

steviez
steviez approved these changes Oct 17, 2024
View reviewed changes
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for getting to this one

@brooksprumo brooksprumo merged commit 1e6e1f5 into anza-xyz:master Oct 17, 2024
40 checks passed
@brooksprumo brooksprumo deleted the fix-test_bank_update_sysvar_account branch October 17, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

@apfitzge apfitzge apfitzge approved these changes

Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky Test: solana-runtime bank::tests::test_bank_update_sysvar_account
3 participants
@brooksprumo @steviez @apfitzge