Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips merkle-based accounts verification when accounts lt hash is enabled #3208

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Oct 17, 2024

Problem

When the accounts lt hash is enabled, startup accounts verification still does both the new, lattice-based, verification and the old, merkle-based, verification. We should only do one or the other.

Summary of Changes

If accounts lt hash is enabled, only do lattice-based accounts verification.

Note for reviewers: I recommend ignoring whitespace in the diff.

@brooksprumo brooksprumo self-assigned this Oct 17, 2024
@brooksprumo brooksprumo marked this pull request as ready for review October 17, 2024 20:12
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 114ab4d into anza-xyz:master Oct 17, 2024
40 checks passed
@brooksprumo brooksprumo deleted the lthash/snapshot-verify branch October 17, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants