This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Adding restart policy fix for v2 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun integration test please |
ash211
approved these changes
May 25, 2017
|
Looks fine. Merging. |
|
Does this need to be on executors also? |
|
Hmm.. the executors restart and try to reconnect, which is recovery behavior we want in that case. I don't think there is a reason to prevent executor pods restarting after errors. If it is a transient error, it will eventually succeed, and if it isn't, we should fail the job after a threshold. cc @varunkatta |
foxish
added a commit
that referenced
this pull request
Jul 24, 2017
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
…ark-on-k8s#312) This reverts commit e017c20.
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
cc @apache-spark-on-k8s/contributors