-
Notifications
You must be signed in to change notification settings - Fork 118
Add libc6-compat to base spark docker image to fix issue with parquet… #550
base: branch-2.2-kubernetes
Are you sure you want to change the base?
Add libc6-compat to base spark docker image to fix issue with parquet… #550
Conversation
@ssuchter @kimoonkim @ash211 Can you verify this? |
cc/ @liyinan926 @mccheah |
rerun integration tests please |
I have run the integration tests with this change and I have the same random failures as described in #571. IMHO this change does not impact the integration tests. The question is more |
Thank you for your work on this! |
a12bfe3
to
0612195
Compare
rerun integration tests please |
On the +/- 20 integration test runs I have run on my env, I had I think 2 runs with 100% green. The fully successful ones were not with this branch. Let's wait on a fix (wherever it is on my env or on the integration tests process) to merge. |
this apache#19717 (comment) is saying libc6-compat doesn't fix the problem, do we have an alternative solution, and we need a fix up stream as well (soon)? |
@felixcheung, I think we should switch the base image - since alpine is known to have such issues. ubuntu/centos might be good choices - but we should get that running in our branch first and tested before pushing upstream. |
|
I was thinking more of having people test it out in prod - but yeah, we could write some integration testing as well. An set of integration tests marked as [conformance] to preserve existing behavior makes sense. We want those to work regardless of the base image chosen. |
We can start with manual test (although it shows already its limits as it can work in some env, and not in others). Running those conformance tests (so not located in the integration repo/module) against various base images would be the target (although a lot of work). |
sgtm. I think we should merge this change anyway because it's in upstream. @kimoonkim @ssuchter, can you PTAL at the integration tests? They seem wedged for some reason. |
Sgtm
|
retest this please |
What changes were proposed in this pull request?
Add libc6-compat to base spark docker image to fix issue with parquet ld-linux-x86-64.so.2 not found
How was this patch tested?
With current docker images, basic dataframe manipulation works fine but saving to parquet format returns an exception du to missing linux library:
This PR add to the spark-base image the needed Alpine package (libc6-compat) - Not sure if we want to make the base image more fat or if it would be better to target the 3 driver images.
To test, just rebuild and run
List(1, 2, 3).toDS.write.parquet("/tmp/ds1")