fix: scale type category missing ordinal

apache-superset · May 31, 2019 · 1516ed4 · 1516ed4
1 parent 1d8d7bc
commit 1516ed4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/superset-ui-preset-chart-xy/src/encodeable/parsers/extractScale.ts b/packages/superset-ui-preset-chart-xy/src/encodeable/parsers/extractScale.ts
@@ -48,7 +48,7 @@ export interface ScaleAgent<Output extends Value> {
     | ScaleOrdinal<{ toString(): string }, Output>
     | ScalePoint<{ toString(): string }>
     | ScaleBand<{ toString(): string }>;
-  scaleTypeCategory: 'continuous' | 'discrete' | 'discretizing';
+  scaleTypeCategory: 'continuous' | 'discrete' | 'discretizing' | undefined;
 }
 
 export interface ScaleTypeToD3ScaleType<Output> {
@@ -201,7 +201,7 @@ function createScale<Output extends Value>(
 }
 
 const continuousScaleTypes = new Set(['linear', 'pow', 'sqrt', 'symlog', 'log', 'time', 'utc']);
-const discreteScaleTypes = new Set(['band', 'point']);
+const discreteScaleTypes = new Set(['band', 'point', 'ordinal']);
 const discretizingScaleTypes = new Set(['bin-ordinal', 'quantile', 'quantize', 'threshold']);
 
 function getScaleTypeCategory(scaleType: ScaleType) {
@@ -215,7 +215,9 @@ function getScaleTypeCategory(scaleType: ScaleType) {
     return 'discretizing';
   }
 
-  throw new Error(`Unknown scaleType ${scaleType}`);
+  console.warn(`Unknown scaleType ${scaleType}`);
+
+  return undefined;
 }
 
 export default function extractScale<Output extends Value>(