Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JLine past 3.21.0 (non-trivial) #3485

Closed
ctubbsii opened this issue Jun 12, 2023 · 2 comments · Fixed by #3895
Closed

Update JLine past 3.21.0 (non-trivial) #3485

ctubbsii opened this issue Jun 12, 2023 · 2 comments · Fixed by #3895
Assignees
@EdColeman
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Milestone
2.1.3

Comments

@ctubbsii
Copy link
Member

Updating to 3.22.0 caused problems (#3446). That needs to be investigated further. Depending on the outcome of that investigation, we could choose one of:

  1. figure out how to achieve the desired behavior in the newer versions
  2. get a patch pushed upstream to JLine, and update to that newer version
  3. accept the change in behavior and update to the newer versions anyway (let users know of any workarounds that exist)
@ctubbsii ctubbsii added the enhancement This issue describes a new feature, improvement, or optimization. label Jun 12, 2023
@ctubbsii ctubbsii mentioned this issue Jun 12, 2023
Closed
@ctubbsii
Copy link
Member Author

ctubbsii commented Aug 14, 2023 •
edited
Loading

The underlying issue should be fixed in 3.23.1 (in jline/jline3#854), but JLine hasn't released that version yet.

jmark99 added a commit to jmark99/accumulo that referenced this issue Aug 25, 2023
@jmark99
Adjust shell to indicate how re-authtication occurs
55205f3 
This PR adds presents additional information to the shell when the
re-authentication is automatically performed using the value from
accumulo-client.properties.

Once merged, the update will be applied to 3.x where it corrects an
situation where an endless loop can be triggered when attempting
re-authentication if the accumulo-client.properties file password
is altered after initial setup.

See apache#3485 for more detail.
jmark99 added a commit that referenced this issue Aug 28, 2023
@jmark99
Adjust shell to indicate how re-authtication occurs (#3726)
fc793ec 
This PR adds presents additional information to the shell when the re-authentication is automatically performed using the value from accumulo-client.properties.

Once merged, the update will be applied to 3.x where it corrects a situation where an endless loop can be triggered when attempting re-authentication if the accumulo-client.properties file password is altered after initial setup.

See #3485 for more detail.

Closes #
EdColeman pushed a commit to EdColeman/accumulo that referenced this issue Sep 11, 2023
@jmark99
Adjust shell to indicate how re-authtication occurs (apache#3726)
3656df9 
This PR adds presents additional information to the shell when the re-authentication is automatically performed using the value from accumulo-client.properties.

Once merged, the update will be applied to 3.x where it corrects a situation where an endless loop can be triggered when attempting re-authentication if the accumulo-client.properties file password is altered after initial setup.

See apache#3485 for more detail.

Closes #
@EdColeman EdColeman self-assigned this Oct 26, 2023
@EdColeman
Copy link
Contributor

JLine 3.24.0 was released - working on testing it now.

@EdColeman EdColeman mentioned this issue Oct 26, 2023
Merged
@asfgit asfgit closed this as completed in 75e959a Oct 27, 2023
@ctubbsii ctubbsii modified the milestones: 3.1.0, 2.1.3 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdColeman EdColeman

Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Milestone
2.1.3
Development

Successfully merging a pull request may close this issue.

Fixes 3485. Update jline version to 3.24.0 EdColeman/accumulo
2 participants
@ctubbsii @EdColeman