[Landing pages] Replace use case video iframes with links #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: merobi-hub <[email protected]>
Signed-off-by: merobi-hub <[email protected]>
merobi-hub
changed the title
iframes with links 
potiuk
approved these changes
Apr 10, 2024
|
proably best choice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedding videos from external sources, as we are trying to do with the use case videos, is frowned upon by the ASF due to concerns about violating the GDPR. Currently, the videos are broken because the iframes violate the site's CSP, which is probably coming from ASF infra. Fixing the iframes, even if we could, seems ill-advised and could take time.
This replaces the iframes with links employing
imgtags. The appearance of the pages is unchanged.