Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Wei Lee to committer list #996

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 4, 2024

No description provided.

@Lee-W Lee-W force-pushed the add-weilee-to-committer-list branch from 2c9267e to 587ae05 Compare April 4, 2024 09:23
"name": "Wei Lee",
"github": "https://github.com/Lee-W",
"image": "https://github.com/Lee-W.png",
"nick": "weilee"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"nick": "weilee"
"nick": "Lee-W"

This should be your github username. Might be worth renaming this lol.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I though it could be any nick name haha. Justu updated it

@Lee-W Lee-W force-pushed the add-weilee-to-committer-list branch from 587ae05 to 43cd4e8 Compare April 8, 2024 07:43
@Lee-W Lee-W requested a review from jedcunningham April 8, 2024 07:44
Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations Wei! 🥳

@jedcunningham jedcunningham merged commit e1c24fb into main Apr 8, 2024
1 check passed
@jedcunningham jedcunningham deleted the add-weilee-to-committer-list branch April 8, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants