Chart: Add warning about changing/adding metrics mappings (#36960)

We might still miss some, but this is better than nothing?
apache · Jan 23, 2024 · 1c958a2 · 1c958a2
1 parent d78a114
commit 1c958a2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/chart/files/statsd-mappings.yml b/chart/files/statsd-mappings.yml
@@ -15,6 +15,12 @@
 # specific language governing permissions and limitations
 # under the License.
 ---
+# {{/*
+# WARNING: Be aware that most changes to these mappings will break backwards compatibility!
+# E.g. moving to labels will break existing dashboards.
+# instead utilize `statsd.overrideMappings` in your environment, until we have version 2
+# of the helm chart.
+# */}}
 mappings:
   # Map dot separated stats to labels
   - match: airflow.dagrun.dependency-check.*.*

diff --git a/chart/templates/configmaps/statsd-configmap.yaml b/chart/templates/configmaps/statsd-configmap.yaml
@@ -44,7 +44,7 @@ data:
     mappings:
       {{- toYaml .Values.statsd.overrideMappings | nindent 6 }}
     {{- else }}
-      {{- .Files.Get "files/statsd-mappings.yml" | nindent 4 }}
+      {{- tpl (.Files.Get "files/statsd-mappings.yml") . | nindent 4 }}
       {{- if .Values.statsd.extraMappings }}
         {{- toYaml .Values.statsd.extraMappings | nindent 6 }}
       {{- end }}