Skip to content

Commit

Permalink
Airflow 3: store_serialized_dags deprecated parameter usage removal (#…
Browse files Browse the repository at this point in the history
…40931)

* store_serialized_dags parameter usage removal

* news fragment added
  • Loading branch information
dirrao authored Aug 16, 2024
1 parent 55d49cc commit 4361596
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 23 deletions.
23 changes: 0 additions & 23 deletions airflow/models/dagbag.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import sys
import textwrap
import traceback
import warnings
import zipfile
from datetime import datetime, timedelta
from pathlib import Path
Expand All @@ -47,7 +46,6 @@
AirflowDagCycleException,
AirflowDagDuplicatedIdException,
AirflowException,
RemovedInAirflow3Warning,
)
from airflow.listeners.listener import get_listener_manager
from airflow.models.base import Base
Expand Down Expand Up @@ -113,7 +111,6 @@ class DagBag(LoggingMixin):
to filter python modules to scan for dags.
:param read_dags_from_db: Read DAGs from DB if ``True`` is passed.
If ``False`` DAGs are read from python files.
:param store_serialized_dags: deprecated parameter, same effect as `read_dags_from_db`
:param load_op_links: Should the extra operator link be loaded via plugins when
de-serializing the DAG? This flag is set to False in Scheduler so that Extra Operator links
are not loaded to not run User code in Scheduler.
Expand All @@ -126,7 +123,6 @@ def __init__(
include_examples: bool | ArgNotSet = NOTSET,
safe_mode: bool | ArgNotSet = NOTSET,
read_dags_from_db: bool = False,
store_serialized_dags: bool | None = None,
load_op_links: bool = True,
collect_dags: bool = True,
):
Expand All @@ -143,15 +139,6 @@ def __init__(
safe_mode if isinstance(safe_mode, bool) else conf.getboolean("core", "DAG_DISCOVERY_SAFE_MODE")
)

if store_serialized_dags:
warnings.warn(
"The store_serialized_dags parameter has been deprecated. "
"You should pass the read_dags_from_db parameter.",
RemovedInAirflow3Warning,
stacklevel=2,
)
read_dags_from_db = store_serialized_dags

dag_folder = dag_folder or settings.DAGS_FOLDER
self.dag_folder = dag_folder
self.dags: dict[str, DAG] = {}
Expand Down Expand Up @@ -182,16 +169,6 @@ def size(self) -> int:
""":return: the amount of dags contained in this dagbag"""
return len(self.dags)

@property
def store_serialized_dags(self) -> bool:
"""Whether to read dags from DB."""
warnings.warn(
"The store_serialized_dags property has been deprecated. Use read_dags_from_db instead.",
RemovedInAirflow3Warning,
stacklevel=2,
)
return self.read_dags_from_db

@property
def dag_ids(self) -> list[str]:
"""
Expand Down
1 change: 1 addition & 0 deletions newsfragments/40931.significant.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed dagbag deprecated ``store_serialized_dags`` parameter. Please use ``read_dags_from_db`` parameter.

0 comments on commit 4361596

Please sign in to comment.