Skip to content

Commit

Permalink
Mark two tests as (trigger and deps) as flaky (#40144)
Browse files Browse the repository at this point in the history
Those two tests are failing sometimes when run in parallel setting.
Not very frequently but frequently enough to be annoying, Seems that
they are really re-runnable and apparently there are some racy
behaviours triggering it, so marking them as flaky should help.
  • Loading branch information
potiuk authored Jun 8, 2024
1 parent 0478e24 commit 48b6190
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/ti_deps/deps/test_trigger_rule_dep.py
Original file line number Diff line number Diff line change
Expand Up @@ -1135,6 +1135,7 @@ def test_mapped_task_upstream_removed_with_all_failed_trigger_rules(

_test_trigger_rule(ti=ti, session=session, flag_upstream_failed=flag_upstream_failed)

@pytest.mark.flaky(reruns=5)
@pytest.mark.parametrize(
"trigger_rule", [TriggerRule.NONE_FAILED, TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS]
)
Expand Down
1 change: 1 addition & 0 deletions tests/triggers/test_external_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ async def test_task_workflow_trigger_success(self, mock_get_count):
with pytest.raises(StopAsyncIteration):
await gen.__anext__()

@pytest.mark.flaky(reruns=5)
@mock.patch("airflow.triggers.external_task._get_count")
@pytest.mark.asyncio
async def test_task_workflow_trigger_failed(self, mock_get_count):
Expand Down

0 comments on commit 48b6190

Please sign in to comment.