-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Validate airflow chart values.yaml & values.schema.json (#11990)
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema (cherry picked from commit e238b88)
- Loading branch information
Showing
5 changed files
with
229 additions
and
118 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
import json | ||
import os | ||
import unittest | ||
import yaml | ||
|
||
from jsonschema import validate | ||
|
||
|
||
CHART_FOLDER = os.path.dirname(os.path.dirname(__file__)) | ||
|
||
|
||
class ChartQualityTest(unittest.TestCase): | ||
def test_values_validate_schema(self): | ||
with open(os.path.join(CHART_FOLDER, "values.yaml"), "r") as f: | ||
values = yaml.safe_load(f) | ||
with open(os.path.join(CHART_FOLDER, "values.schema.json"), "r") as f: | ||
schema = json.load(f) | ||
|
||
# Add extra restrictions just for the tests to make sure | ||
# we don't forget to update the schema if we add a new property | ||
schema["additionalProperties"] = False | ||
schema["minProperties"] = len(schema["properties"].keys()) | ||
|
||
# shouldn't raise | ||
validate(instance=values, schema=schema) |
Oops, something went wrong.