Skip to content

Commit

Permalink
Fix failing MinSQLAlchemy test after moving sqlalchemy spec (#38445)
Browse files Browse the repository at this point in the history
  • Loading branch information
potiuk authored Mar 25, 2024
1 parent 20cb9f1 commit a9cfa84
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/run-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
BACKEND_VERSION: "${{ matrix.backend-version }}"
DEBUG_RESOURCES: "${{ inputs.debug-resources }}"
DOWNGRADE_SQLALCHEMY: "${{ inputs.downgrade-sqlalchemy }}"
DOWN_PENDULUM: "${{ inputs.downgrade-pendulum }}"
DOWNGRADE_PENDULUM: "${{ inputs.downgrade-pendulum }}"
ENABLE_COVERAGE: "${{ inputs.run-coverage }}"
IMAGE_TAG: "${{ inputs.image-tag }}"
INCLUDE_SUCCESS_OUTPUTS: ${{ inputs.include-success-outputs }}
Expand Down
12 changes: 6 additions & 6 deletions Dockerfile.ci
Original file line number Diff line number Diff line change
Expand Up @@ -1049,11 +1049,11 @@ function check_pydantic() {
}


function check_download_sqlalchemy() {
function check_downgrade_sqlalchemy() {
if [[ ${DOWNGRADE_SQLALCHEMY=} != "true" ]]; then
return
fi
min_sqlalchemy_version=$(grep "\"sqlalchemy>=" pyproject.toml | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
min_sqlalchemy_version=$(grep "\"sqlalchemy>=" hatch_build.py | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
echo
echo "${COLOR_BLUE}Downgrading sqlalchemy to minimum supported version: ${min_sqlalchemy_version}${COLOR_RESET}"
echo
Expand All @@ -1062,11 +1062,11 @@ function check_download_sqlalchemy() {
pip check
}

function check_download_pendulum() {
function check_downgrade_pendulum() {
if [[ ${DOWNGRADE_PENDULUM=} != "true" ]]; then
return
fi
min_pendulum_version=$(grep "\"pendulum>=" pyproject.toml | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
min_pendulum_version=$(grep "\"pendulum>=" hatch_build.py | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
echo
echo "${COLOR_BLUE}Downgrading pendulum to minimum supported version: ${min_pendulum_version}${COLOR_RESET}"
echo
Expand Down Expand Up @@ -1104,8 +1104,8 @@ determine_airflow_to_use
environment_initialization
check_boto_upgrade
check_pydantic
check_download_sqlalchemy
check_download_pendulum
check_downgrade_sqlalchemy
check_downgrade_pendulum
check_run_tests "${@}"

exec /bin/bash "${@}"
Expand Down
12 changes: 6 additions & 6 deletions scripts/docker/entrypoint_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,11 @@ function check_pydantic() {


# Download minimum supported version of sqlalchemy to run tests with it
function check_download_sqlalchemy() {
function check_downgrade_sqlalchemy() {
if [[ ${DOWNGRADE_SQLALCHEMY=} != "true" ]]; then
return
fi
min_sqlalchemy_version=$(grep "\"sqlalchemy>=" pyproject.toml | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
min_sqlalchemy_version=$(grep "\"sqlalchemy>=" hatch_build.py | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
echo
echo "${COLOR_BLUE}Downgrading sqlalchemy to minimum supported version: ${min_sqlalchemy_version}${COLOR_RESET}"
echo
Expand All @@ -285,11 +285,11 @@ function check_download_sqlalchemy() {
}

# Download minimum supported version of pendulum to run tests with it
function check_download_pendulum() {
function check_downgrade_pendulum() {
if [[ ${DOWNGRADE_PENDULUM=} != "true" ]]; then
return
fi
min_pendulum_version=$(grep "\"pendulum>=" pyproject.toml | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
min_pendulum_version=$(grep "\"pendulum>=" hatch_build.py | sed "s/.*>=\([0-9\.]*\).*/\1/" | xargs)
echo
echo "${COLOR_BLUE}Downgrading pendulum to minimum supported version: ${min_pendulum_version}${COLOR_RESET}"
echo
Expand Down Expand Up @@ -328,8 +328,8 @@ determine_airflow_to_use
environment_initialization
check_boto_upgrade
check_pydantic
check_download_sqlalchemy
check_download_pendulum
check_downgrade_sqlalchemy
check_downgrade_pendulum
check_run_tests "${@}"

# If we are not running tests - just exec to bash shell
Expand Down

0 comments on commit a9cfa84

Please sign in to comment.