Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DAG operator status accessibility for the color blind #13114

Closed
atolopko-czi opened this issue Dec 16, 2020 · 9 comments
Closed

Improve DAG operator status accessibility for the color blind #13114

atolopko-czi opened this issue Dec 16, 2020 · 9 comments
Labels

Comments

@atolopko-czi
Copy link

The coloration of DAG operator statuses in the DAG "Tree" and "Graph" views are not easy to discern by color blind individuals. There is no textual representation of the status in the hover popup window.

Use case / motivation

Are you willing to submit a PR?

Yes

Related Issues

No

@atolopko-czi atolopko-czi added the kind:feature Feature Requests label Dec 16, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 16, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@eladkal
Copy link
Contributor

eladkal commented Dec 16, 2020

What Airflow version are you running? There has been improve in that area in 1.10.11
see issue #7843, PR #9520, docs

Also in Graph View when you over one of the statuses in the legend it makes all the tasks in that status highlighted:
video

Can you give more information? (maybe a mock up of what you expect?)

@atolopko-czi
Copy link
Author

Version : 1.10.10

The Tree view status-hover highlighting is indeed helpful, and I was unaware! The Graph view doesn't provide the same feature, which would be helpful. So it would still be helpful if these popups contained the operator status:
image

Use of custom colors may also be able to address this for particular degrees of color blindness, which I will try.

@kaxil
Copy link
Member

kaxil commented Dec 17, 2020

@ashb
Copy link
Member

ashb commented Dec 17, 2020

And if you can suggest new default colours we can look at changing them too.

@eladkal
Copy link
Contributor

eladkal commented Jan 29, 2021

@atolopko-czi Do you think there are still issues needs to be addressed? If you can please describe your suggestions

@atolopko-czi
Copy link
Author

I still feel it is helpful if the Tree view status hover popups simply contained the operator status as text. Colors can be useful conveyors of information, but text is more accessible for the color-blind. I have not tried setting different default colors, since that would require consensus across our organization.

@kaxil
Copy link
Member

kaxil commented Feb 1, 2021

image

The tree view in 2.0.0 should already have that

@atolopko-czi
Copy link
Author

Will upgrade! Thanks @kaxil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants