Allow changing Task States Colors #9520

kaxil · 2020-06-25T22:54:29Z

The main purpose of this PR is to allow Colorblind Friendly UI

Stock Screenshots:

Steps to change colors:

Create airflow_local_settings.py file and put in on PYTHONPATH. (example put that file under $AIRFLOW_HOME/config/airflow_local_settings.py with the following contents:

STATE_COLORS = {
    "queued": 'darkgray',
    "running": '#01FF70',
    "success": '#2ECC40',
    "failed": 'firebrick',
    "up_for_retry": 'yellow',
    "up_for_reschedule": 'turquoise',
    "upstream_failed": 'orange',
    "skipped": 'darkorchid',
    "scheduled": 'tan',
}

Screenshots with the above changes:

Make sure to mark the boxes below before creating PR: [x]

Description above provides context of the change
Unit tests coverage for changes (not needed for documentation changes)
Target Github ISSUE in description if exists
Commits follow "How to write a good git commit message"
Relevant documentation is updated including usage instructions.
I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

kaxil · 2020-06-25T23:24:30Z

Once the PR is approved, I will add some docs on changing colors

Acehaidrey · 2020-06-26T07:24:18Z

Hi @kaxil thanks for your work on this. Quick question from your notes I'm not seeing how to make a colorblind friendly UI here though as a user configuration. If we just have local_configuration, is the idea that we just have this configurable for the webserver for everyone. I thought it was to make it configurable at a per person level.

kaxil · 2020-06-28T15:32:02Z

Hi @kaxil thanks for your work on this. Quick question from your notes I'm not seeing how to make a colorblind friendly UI here though as a user configuration. If we just have local_configuration, is the idea that we just have this configurable for the webserver for everyone. I thought it was to make it configurable at a per person level.

Hey, yes this PR won't allow per-user change. It would only allow per deployment change. I wanted to address custom colors per deployment for 1.10.11 and we can take a look at per-user change at a later stage (maybe for 2.0)

Acehaidrey · 2020-06-29T06:20:06Z

I see makes sense. The colors were hardcoded up to this point and weren't customizable at all - just want to make sure that my understanding is correct.

ashb · 2020-06-29T11:22:31Z

airflow/www/views.py

@@ -336,6 +337,7 @@ def get_int_arg(value, default=0):

        state_color_mapping = State.state_color.copy()
        state_color_mapping["null"] = state_color_mapping.pop(None)
+        state_color_mapping.update(STATE_COLORS)


Isn't this already done from https://github.com/apache/airflow/pull/9520/files#diff-e198cdb4d2a7b4801616a067e6cbd82eR80

in f9601c2

kaxil · 2020-06-29T14:28:50Z

Rebased on latest master

ashb · 2020-06-29T14:28:52Z

Happy with this now @kaxil?

kaxil · 2020-06-29T14:33:52Z

Happy with this now @kaxil?

Yup

preston-m-price · 2020-06-29T15:46:18Z

Thanks for this change!

(cherry picked from commit e1108d4)

Feature was added in apache#9520

Feature was added in #9520

Feature was added in #9520 (cherry picked from commit 65855e5)

(cherry picked from commit e1108d4)

Feature was added in apache#9520 (cherry picked from commit 65855e5)

Feature was added in apache/airflow#9520 (cherry picked from commit 65855e558f9b070004ba817e8cf94fd834d2a67a) GitOrigin-RevId: 1303b858ea6b6bd545b97e6e3ec69614f69d2dd4

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

kaxil added this to the Airflow 1.10.11 milestone Jun 25, 2020

kaxil requested a review from ashb June 25, 2020 22:54

boring-cyborg bot added the area:webserver Webserver related Issues label Jun 25, 2020

kaxil changed the title ~~Config states~~ Allow changing Task States Colors Jun 25, 2020

kaxil mentioned this pull request Jun 25, 2020

Colorblind friendly UI #7843

Closed

kaxil requested review from potiuk and dimberman June 25, 2020 23:26

Acehaidrey approved these changes Jun 29, 2020

View reviewed changes

ashb reviewed Jun 29, 2020

View reviewed changes

kaxil force-pushed the config-states branch from f9601c2 to 428836f Compare June 29, 2020 13:41

kaxil added 7 commits June 29, 2020 15:26

Allow configuring Task States

976f2f2

fixup! Allow configuring Task States

e03a8bd

fixup! fixup! Allow configuring Task States

27a2dbb

fixup! fixup! fixup! Allow configuring Task States

377b06e

fixup! fixup! fixup! fixup! Allow configuring Task States

a3b3e4e

fixup! fixup! fixup! fixup! fixup! Allow configuring Task States

09b9b85

fixup! fixup! fixup! fixup! fixup! fixup! Allow configuring Task States

8469ccd

kaxil force-pushed the config-states branch from 428836f to 8469ccd Compare June 29, 2020 14:26

ashb approved these changes Jun 29, 2020

View reviewed changes

kaxil merged commit e1108d4 into apache:master Jun 29, 2020

kaxil deleted the config-states branch June 29, 2020 15:12

kaxil added a commit that referenced this pull request Jun 29, 2020

Allow changing Task States Colors (#9520)

f63b249

(cherry picked from commit e1108d4)

kaxil added a commit to astronomer/airflow that referenced this pull request Jul 1, 2020

Add docs to change Colors on the Webserver

eb71e6f

Feature was added in apache#9520

kaxil mentioned this pull request Jul 1, 2020

Add docs to change Colors on the Webserver #9607

Merged

6 tasks

kaxil added a commit that referenced this pull request Jul 1, 2020

Add docs to change Colors on the Webserver (#9607)

65855e5

Feature was added in #9520

kaxil added a commit that referenced this pull request Jul 1, 2020

Add docs to change Colors on the Webserver (#9607)

127104b

Feature was added in #9520 (cherry picked from commit 65855e5)

kaxil added a commit that referenced this pull request Jul 2, 2020

Add docs to change Colors on the Webserver (#9607)

1303b85

Feature was added in #9520 (cherry picked from commit 65855e5)

preston-m-price mentioned this pull request Jul 7, 2020

Merge accessible colors github/incubator-airflow#33

Merged

eladkal mentioned this pull request Dec 16, 2020

Improve DAG operator status accessibility for the color blind #13114

Closed

cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021

Allow changing Task States Colors (apache#9520)

614e7fd

(cherry picked from commit e1108d4)

cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021

Add docs to change Colors on the Webserver (apache#9607)

7e620b1

Feature was added in apache#9520 (cherry picked from commit 65855e5)

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021

Add docs to change Colors on the Webserver (#9607)

b6f26bf

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021

Add docs to change Colors on the Webserver (#9607)

7e2faba

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

eladkal mentioned this pull request Sep 20, 2021

Color Blindness - Color Schemas #18391

Closed

2 tasks

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021

Add docs to change Colors on the Webserver (#9607)

9924612

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 25, 2021

Add docs to change Colors on the Webserver (#9607)

35ca1d1

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 9, 2022

Add docs to change Colors on the Webserver (#9607)

fc018f7

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2022

Add docs to change Colors on the Webserver (#9607)

f573e5a

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 6, 2022

Add docs to change Colors on the Webserver (#9607)

2bebea4

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 8, 2022

Add docs to change Colors on the Webserver (#9607)

67516d1

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022

Add docs to change Colors on the Webserver (#9607)

a5ae0c4

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022

Add docs to change Colors on the Webserver (#9607)

c9d0d1a

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022

Add docs to change Colors on the Webserver (#9607)

cad7689

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022

Add docs to change Colors on the Webserver (#9607)

27eaa7e

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023

Add docs to change Colors on the Webserver (#9607)

bd93cf8

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 11, 2024

Add docs to change Colors on the Webserver (#9607)

df2fe45

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024

Add docs to change Colors on the Webserver (#9607)

41e8097

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2024

Add docs to change Colors on the Webserver (#9607)

b993d25

Feature was added in apache/airflow#9520 GitOrigin-RevId: 65855e558f9b070004ba817e8cf94fd834d2a67a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow changing Task States Colors #9520

Allow changing Task States Colors #9520

kaxil commented Jun 25, 2020 •

edited

Loading

kaxil commented Jun 25, 2020

Acehaidrey commented Jun 26, 2020

kaxil commented Jun 28, 2020

Acehaidrey commented Jun 29, 2020

ashb Jun 29, 2020

kaxil Jun 29, 2020

kaxil Jun 29, 2020

kaxil commented Jun 29, 2020

ashb commented Jun 29, 2020

kaxil commented Jun 29, 2020

preston-m-price commented Jun 29, 2020

Allow changing Task States Colors #9520

Allow changing Task States Colors #9520

Conversation

kaxil commented Jun 25, 2020 • edited Loading

kaxil commented Jun 25, 2020

Acehaidrey commented Jun 26, 2020

kaxil commented Jun 28, 2020

Acehaidrey commented Jun 29, 2020

ashb Jun 29, 2020

Choose a reason for hiding this comment

kaxil Jun 29, 2020

Choose a reason for hiding this comment

kaxil Jun 29, 2020

Choose a reason for hiding this comment

kaxil commented Jun 29, 2020

ashb commented Jun 29, 2020

kaxil commented Jun 29, 2020

preston-m-price commented Jun 29, 2020

kaxil commented Jun 25, 2020 •

edited

Loading