Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler fails if task is removed at runtime #13464

Closed
soltanianalytics opened this issue Jan 4, 2021 · 0 comments · Fixed by #14057
Closed

Scheduler fails if task is removed at runtime #13464

soltanianalytics opened this issue Jan 4, 2021 · 0 comments · Fixed by #14057
Labels
affected_version:2.0 Issues Reported for 2.0 area:Scheduler including HA (high availability) scheduler kind:bug This is a clearly a bug priority:medium Bug that should be fixed before next release but would not block a release
Milestone
Airflow 2.0.1

Comments

@soltanianalytics
Copy link
Contributor

soltanianalytics commented Jan 4, 2021 •
edited by kaxil
Loading

Apache Airflow version: 2.0.0, LocalExecutor

Environment: Docker on Win10 with WSL, official Python3.8 image

What happened:

When a DAG is running, and I delete task from the running DAG, the scheduler fails. When using Docker, upon automatic restart of the scheduler, the scheduler just fails again, perpetually.

image

Note: I don't know if the task itself was running at the time, but I would guess it was.

What you expected to happen:

The scheduler should understand that the task is not part of the DAG anymore and not fail.

How to reproduce it:

  • Create a DAG with multiple tasks
  • Let it run
  • While running, delete one of the tasks from the source code
  • See the scheduler break
@soltanianalytics soltanianalytics added the kind:bug This is a clearly a bug label Jan 4, 2021
@eladkal eladkal added area:Scheduler including HA (high availability) scheduler affected_version:2.0 Issues Reported for 2.0 labels Jan 7, 2021
@kaxil kaxil added this to the Airflow 2.0.1 milestone Jan 18, 2021
@kaxil kaxil added the priority:medium Bug that should be fixed before next release but would not block a release label Jan 19, 2021
@kaxil kaxil modified the milestone: Airflow 2.0.1 Jan 19, 2021
kaxil added a commit to astronomer/airflow that referenced this issue Feb 4, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime
eb2b2e2 
closes apache#13464
@kaxil kaxil mentioned this issue Feb 4, 2021
Merged
kaxil added a commit that referenced this issue Feb 4, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
eb78a8b 
closes #13464
kaxil added a commit that referenced this issue Feb 4, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
51cd910 
closes #13464

(cherry picked from commit eb78a8b)
kaxil added a commit to astronomer/airflow that referenced this issue Apr 12, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (apache#14057)
cfb5621 
closes apache#13464

(cherry picked from commit eb78a8b)
(cherry picked from commit 51cd910)
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 16, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
fab5e63 
closes apache/airflow#13464

(cherry picked from commit eb78a8b86c6e372bbf4bfacb7628b154c16aa16b)

GitOrigin-RevId: 51cd910a5e9d1990b28aa820aaf7f44bc664604f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
e14c5dd 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 23, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
1b05b06 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 27, 2021
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
5d9b89c 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Mar 10, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
26935fc 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 4, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
d2a9bd8 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 7, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
2839809 
closes apache/airflow#13464

(cherry picked from commit eb78a8b86c6e372bbf4bfacb7628b154c16aa16b)

GitOrigin-RevId: 51cd910a5e9d1990b28aa820aaf7f44bc664604f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jul 9, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
da11d36 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Aug 27, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
27ad483 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 4, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
c07fb4b 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 7, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
3a91a21 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Dec 7, 2022
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
a7d751c 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jan 27, 2023
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
bb595b7 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this issue Sep 12, 2024
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
dff6127 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this issue Sep 12, 2024
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
47a0648 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2024
@kaxil
Bugfix: Scheduler fails if task is removed at runtime (#14057)
5df1fc6 
closes apache/airflow#13464

GitOrigin-RevId: eb78a8b86c6e372bbf4bfacb7628b154c16aa16b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected_version:2.0 Issues Reported for 2.0 area:Scheduler including HA (high availability) scheduler kind:bug This is a clearly a bug priority:medium Bug that should be fixed before next release but would not block a release
Projects
None yet
Milestone
Airflow 2.0.1
Development

Successfully merging a pull request may close this issue.

Bugfix: Scheduler fails if task is removed at runtime astronomer/airflow
3 participants
@kaxil @eladkal @soltanianalytics