Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate dag/task UI display name from dag / task id #22073

Closed
1 of 2 tasks
EricGao888 opened this issue Mar 8, 2022 · 22 comments · Fixed by #38446
Closed
1 of 2 tasks

Separate dag/task UI display name from dag / task id #22073

EricGao888 opened this issue Mar 8, 2022 · 22 comments · Fixed by #38446
Labels

Comments

@EricGao888
Copy link
Member

EricGao888 commented Mar 8, 2022

Description

  • Enable users to use their national characters, which are usually non-ASCIIs as the display name of their dags / tasks.

Use case/motivation

UPDATE (by @potiuk):

  • any solution to this one should also include possibility of specifying names for dynamically mapped tasks (individually - per mapped index id)

Related issues

related: #21127
related: #18010
related: #23020

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@EricGao888 EricGao888 added the kind:feature Feature Requests label Mar 8, 2022
@potiuk
Copy link
Member

potiuk commented Mar 8, 2022

I think it's a good feature to have. I hope someone would like to pick it up.

@potiuk
Copy link
Member

potiuk commented Mar 8, 2022

IMHO it is much better (and simpler to implement) than allowing non-ASCII characters for IDs (which is an alternative way of implementing it).

@EricGao888
Copy link
Member Author

I think it's a good feature to have. I hope someone would like to pick it up.

I'd like to take a look into this : )

EricGao888 added a commit to EricGao888/airflow that referenced this issue Mar 9, 2022
@HugoCornu
Copy link

HugoCornu commented Jul 26, 2022

Separating task_id and task display name would allow to have several similar tasks showing the same name.
This would be extremly useful in the context of hyperparameter optimisation.

@potiuk
Copy link
Member

potiuk commented Jul 28, 2022

Sure.Anyone is free to submit PR s imeplementing it @HugoCornu - yourself including.

@koroder
Copy link

koroder commented Aug 2, 2022

@potiuk I am looking to make my first contribution to Airflow. Would it be okay if I work on this issue?

@EricGao888
Copy link
Member Author

@potiuk I am looking to make my first contribution to Airflow. Would it be okay if I work on this issue?

@koroder It's totally fine from my perspective. As currently I'm busy with another project. Thx.

@EricGao888
Copy link
Member Author

@potiuk I am looking to make my first contribution to Airflow. Would it be okay if I work on this issue?

@koroder BTW, you may directly start from this PR if you'd like to. #22118

@koroder
Copy link

koroder commented Aug 2, 2022

Awesome! This is really helpful - I will take it from here.

@uranusjr uranusjr mentioned this issue Aug 4, 2022
2 tasks
@potiuk
Copy link
Member

potiuk commented Aug 4, 2022

Following up from the discussion in #23020 - this feature should also include naming of mapped tasks.

@aleksandr-shel
Copy link
Contributor

aleksandr-shel commented Nov 20, 2022

Hi guys, I would like to take this issue

@potiuk
Copy link
Member

potiuk commented Nov 25, 2022

Feel free.

@eladkal
Copy link
Contributor

eladkal commented Nov 25, 2022

There is a pending PR #27145
I think we are waiting for a dev list discussion on that

@aleksandr-shel
Copy link
Contributor

I put up a pr, would someone be able to take a look, please? #28183

@potiuk
Copy link
Member

potiuk commented Dec 30, 2022

I did. A LOT more needs to be done for that (and I would really like others to chime in there). The #28183 is just the beginning of what should happen in te PR if we are to go in this direction (details in comments in the PR - and I think this is also just beginning of the comments, there are probably more things that will have to be thought about in this PR that I have not yet thought about.

@aleksandr-shel aleksandr-shel removed their assignment Jan 3, 2023
@matthewblock
Copy link

Any more news on this? On top of the use cases listed, it could address the lack of support for changing a DAG name without wiping out its logs and dag_runs.

@potiuk
Copy link
Member

potiuk commented Apr 17, 2023

Well. As all other issues here - likely if there is no changes, nobody works on it. But if you feel like it, you can. I can assign you - the whole history of the issue is there - one of the solutions were vetoed by one of the maintainers - you can read all in the history. Better solution that would solve the problems mentioned there would probably be accepted if someone works on it. Would you like to @matthewblock ?

@alex-astronomer
Copy link
Contributor

+1 on this! Would love to see a feature like this for DAGs that delegate a bunch of work to mapped tasks and have a clear identifier for the work that is being done in that particular dynamic mapped task.

To make this more general I think is also brilliant. I'd love to work on this but we'll see if I get the time...

@matthewblock
Copy link

Well. As all other issues here - likely if there is no changes, nobody works on it. But if you feel like it, you can. I can assign you - the whole history of the issue is there - one of the solutions were vetoed by one of the maintainers - you can read all in the history. Better solution that would solve the problems mentioned there would probably be accepted if someone works on it. Would you like to @matthewblock ?

I'm not a contributor at the moment and unfortunately I won't have the bandwidth to do so in the short term.

@xgao1023
Copy link
Contributor

I created a new PR, it's based on the work from aleksandr-shel but removed slugifiying
#32520

@pnsvk
Copy link

pnsvk commented Mar 18, 2024

do we have a timeline on this ? please update.

@cmarteepants
Copy link
Collaborator

@pnsvk the PR will be included as part of 2.9, which should be released within the next 1.5 weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet